Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): change size of channel_size contract_cache_size #3588

Conversation

avivg-starkware
Copy link
Contributor

No description provided.

@avivg-starkware avivg-starkware marked this pull request as ready for review January 22, 2025 09:58
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Jan 22, 2025

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/cache_size_channel_size_refactor branch 2 times, most recently from 77a4a38 to ffa5c00 Compare January 27, 2025 15:37
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)


crates/blockifier/src/state/contract_class_manager.rs line 30 at r3 (raw file):

use crate::state::global_cache::CachedCairoNative;
use crate::state::global_cache::{CachedCasm, ContractCaches};
pub const DEFAULT_COMPILATION_REQUEST_CHANNEL_SIZE: usize = 20000;

Suggestion:

2000;

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/cache_size_channel_size_refactor branch from ffa5c00 to d3d24b9 Compare January 28, 2025 09:00
Copy link
Contributor Author

@avivg-starkware avivg-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on @noaov1)


crates/blockifier/src/state/contract_class_manager.rs line 30 at r3 (raw file):

use crate::state::global_cache::CachedCairoNative;
use crate::state::global_cache::{CachedCasm, ContractCaches};
pub const DEFAULT_COMPILATION_REQUEST_CHANNEL_SIZE: usize = 20000;

Done.

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

@avivg-starkware avivg-starkware merged commit aeef918 into main-v0.13.4 Jan 28, 2025
11 checks passed
@avivg-starkware avivg-starkware deleted the avivg/blockifier/cache_size_channel_size_refactor branch January 28, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants