Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix papyrus utilities dockerfile #3378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): fix papyrus utilities dockerfile #3378

wants to merge 1 commit into from

Conversation

adi-yakovian-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@adi-yakovian-starkware adi-yakovian-starkware force-pushed the adi/ci/fix-papirus_utilities-dockerfile branch 6 times, most recently from 9ce5adb to 9aed49f Compare January 20, 2025 12:36
@adi-yakovian-starkware adi-yakovian-starkware changed the title fix(papyrus_utilities_docker): change included dockerfile path fix(ci): fix papyrus utilities dockerfile Jan 20, 2025
@idan-starkware
Copy link
Collaborator

papyrus_utilities.Dockerfile line 22 at r1 (raw file):


# Starting a new stage so that the final image will contain only the executables.
FROM alpine:3.17.0 AS papyrus_utilities

This will not work because you removed linux-musl..
Suggestion: change to FROM ubuntu:22.04

Also there is no need to specify "AS papyrus_utilities"

idan-starkware
idan-starkware reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@idan-starkware idan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @adi-yakovian-starkware)

@adi-yakovian-starkware adi-yakovian-starkware force-pushed the adi/ci/fix-papirus_utilities-dockerfile branch from 9aed49f to a9f3100 Compare January 27, 2025 07:21
@adi-yakovian-starkware
Copy link
Contributor Author

papyrus_utilities.Dockerfile line 22 at r1 (raw file):

Previously, idan-starkware (Idan Shamam) wrote…

This will not work because you removed linux-musl..
Suggestion: change to FROM ubuntu:22.04

Also there is no need to specify "AS papyrus_utilities"

You're absolutely right! Great catch, thanks :)

@adi-yakovian-starkware adi-yakovian-starkware force-pushed the adi/ci/fix-papirus_utilities-dockerfile branch from a9f3100 to f3eec2a Compare January 28, 2025 08:41
idan-starkware
idan-starkware approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@idan-starkware idan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adi-yakovian-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idan-starkware idan-starkware idan-starkware approved these changes

Assignees

@adi-yakovian-starkware adi-yakovian-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adi-yakovian-starkware @reviewable-StarkWare @idan-starkware