Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(consensus): update ConsensusManagerConfig with new parameters #3340

Open
wants to merge 1 commit into
base: guyn/config/sequencer_context_config
Choose a base branch
from

Conversation

guy-starkware
Copy link
Contributor

@guy-starkware guy-starkware commented Jan 15, 2025

This adds a few missing fields to the ConsensusManagerConfig struct.
One of them is network_config, which is also removed from ConsensusConfig.

The ConsensusConfig needs a few other modifications, but I'll get to them in one of the next PRs.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@guy-starkware guy-starkware marked this pull request as ready for review January 15, 2025 12:46
@guy-starkware guy-starkware force-pushed the guyn/config/sequencer_context_config branch from 527bc74 to a57408c Compare January 15, 2025 13:04
@guy-starkware guy-starkware force-pushed the guyn/config/sequencer_context_config branch from a57408c to 30748e8 Compare January 15, 2025 13:08
@guy-starkware guy-starkware force-pushed the guyn/config/consensus_manager_config branch from 8e1a680 to 4c3caf1 Compare January 15, 2025 13:08
Copy link

Artifacts upload workflows:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants