-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_batcher): emit transaction metrics #3315
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bc76893
to
51fd344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)
crates/starknet_batcher/src/metrics.rs
line 4 at r1 (raw file):
use starknet_api::block::BlockNumber; // Height metrics
x3
Suggestion:
// Height metrics.
1167aae
to
f39c6a2
Compare
51fd344
to
d23dd99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
f39c6a2
to
5dd86d1
Compare
d23dd99
to
1c1cf72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
5dd86d1
to
10e6f4f
Compare
1c1cf72
to
38098fa
Compare
10e6f4f
to
e103c3c
Compare
38098fa
to
9a73366
Compare
e103c3c
to
728e2f1
Compare
9a73366
to
ef7ee30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
728e2f1
to
40f30b0
Compare
ef7ee30
to
8415537
Compare
Merge activity
|
8415537
to
363b17c
Compare
No description provided.