Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_batcher): emit transaction metrics #3315

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

yair-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

yair-starkware commented Jan 14, 2025

@yair-starkware yair-starkware force-pushed the yair/metrics/transactions branch from bc76893 to 51fd344 Compare January 14, 2025 15:25
@yair-starkware yair-starkware requested a review from alonh5 January 15, 2025 08:40
@yair-starkware yair-starkware self-assigned this Jan 15, 2025
@yair-starkware yair-starkware marked this pull request as ready for review January 15, 2025 08:40
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)


crates/starknet_batcher/src/metrics.rs line 4 at r1 (raw file):

use starknet_api::block::BlockNumber;

// Height metrics

x3

Suggestion:

// Height metrics.

@yair-starkware yair-starkware force-pushed the yair/metrics/transactions branch from 51fd344 to d23dd99 Compare January 16, 2025 15:09
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@yair-starkware yair-starkware force-pushed the yair/metrics/transactions branch from d23dd99 to 1c1cf72 Compare January 19, 2025 09:41
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@yair-starkware yair-starkware force-pushed the yair/metrics/transactions branch from 1c1cf72 to 38098fa Compare January 19, 2025 11:48
@yair-starkware yair-starkware force-pushed the yair/metrics/transactions branch from 38098fa to 9a73366 Compare January 20, 2025 08:35
@yair-starkware yair-starkware force-pushed the yair/metrics/transactions branch from 9a73366 to ef7ee30 Compare January 20, 2025 08:43
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@yair-starkware yair-starkware force-pushed the yair/metrics/transactions branch from ef7ee30 to 8415537 Compare January 20, 2025 11:07
@yair-starkware yair-starkware changed the base branch from yair/metrics/proposals to main January 20, 2025 14:42
Copy link

graphite-app bot commented Jan 20, 2025

Merge activity

  • Jan 20, 9:52 AM EST: Graphite disabled "merge when ready" on this PR due to: We hit a GitHub rate limit while trying to merge. If you are attempting to merge a large stack, breaking it up into smaller chunks may help..

@yair-starkware yair-starkware force-pushed the yair/metrics/transactions branch from 8415537 to 363b17c Compare January 20, 2025 15:02
@yair-starkware yair-starkware added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 44dcec5 Jan 20, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants