Merge main-v0.13.4 into main #3178
Conversation
Signed-off-by: Dori Medini <[email protected]>
Signed-off-by: Dori Medini <[email protected]>
…ockifier-publish-branch
…blish-branch Dori/merge main blockifier publish branch
…2920) Signed-off-by: Dori Medini <[email protected]>
…ly if native flag is on (#2926)
* chore(blockifier): impl deserialize for versioned_constants * chore(blockifier): remove fee_transfer_gas_cost (#2858)
- No reason to run cargo on release in the ci, and this busts cache - Cargo doc doesn't pick up the usual place we pass -Dwarnings, which is RUSTFLAGS, it needs a special flag RUSTDOCFLAGS (it cannot reference the usual RUSTFLAGS so we have to duplicate) Co-Authored-By: Gilad Chase <[email protected]>
* chore(deployment): cdk8s refactor (#2468) * chore(deployment): get values from sequencer config * chore(deployment): removed set functions * chore(deployment): preparation to remove objects.py * chore(deployment): fixed wrong assert usage, added return type annotations
There was a problem hiding this comment.
Reviewed 1 of 31 files at r2.
Reviewable status: 145 of 178 files reviewed, all discussions resolved
meship-starkware
requested review from
noaov1,
dorimedini-starkware and
Itay-Tsabary-Starkware
|
Benchmark movements: full_committer_flow performance regressed! |
There was a problem hiding this comment.
Reviewed 1 of 7 files at r3.
Reviewable status: 146 of 178 files reviewed, all discussions resolved (waiting on @dorimedini-starkware, @Itay-Tsabary-Starkware, and @noaov1)
meship-starkware
force-pushed
the
meshi/merge-main-v0.13.4-into-main-1736338547
branch
from
5740a25 to
e17ffad
Compare
|
Benchmark movements: |
meship-starkware
force-pushed
the
meshi/merge-main-v0.13.4-into-main-1736338547
branch
from
e17ffad to
b110df4
Compare
|
Benchmark movements: |
…3.4-into-main-1736338547
meship-starkware
force-pushed
the
meshi/merge-main-v0.13.4-into-main-1736338547
branch
from
b110df4 to
231b191
Compare
|
Benchmark movements: full_committer_flow performance regressed! |
…3.4-into-main-1736338547
meship-starkware
force-pushed
the
meshi/merge-main-v0.13.4-into-main-1736338547
branch
from
98036c8 to
6a397db
Compare
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 1 of 31 files at r2.
Reviewable status: 144 of 180 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @Itay-Tsabary-Starkware, and @noaov1)
crates/mempool_test_utils/src/starknet_api_test_utils.rs line 404 at r6 (raw file):
let sender_address = self.sender_address(); self.nonce_manager.borrow_mut().next(sender_address) }
I talked with @ArniStarkware about this. The reason for this change is because of a style error in the documentation. We document this method as a public function docstring, meaning that we intend to make this method public
Code quote:
pub fn next_nonce(&mut self) -> Nonce {
let sender_address = self.sender_address();
self.nonce_manager.borrow_mut().next(sender_address)
}
There was a problem hiding this comment.
Reviewable status: 144 of 180 files reviewed, all discussions resolved (waiting on @dorimedini-starkware, @Itay-Tsabary-Starkware, @meship-starkware, and @noaov1)
crates/mempool_test_utils/src/starknet_api_test_utils.rs line 404 at r6 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
I talked with @ArniStarkware about this. The reason for this change is because of a style error in the documentation. We document this method as a public function docstring, meaning that we intend to make this method public
Also, the said documentation refers to using this method as part of the public API of AccountTransactionGenerator.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 144 of 180 files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware, @meship-starkware, and @noaov1)
There was a problem hiding this comment.
Reviewed 17 of 31 files at r2, 6 of 13 files at r5, 6 of 7 files at r6.
Reviewable status: 173 of 180 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware, @meship-starkware, and @noaov1)
crates/blockifier/cairo_native line 0 at r6 (raw file):
is this equal to the commit on main-v0.13.4?
…3.4-into-main-1736338547
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 143 of 174 files at r1, 21 of 31 files at r2, 9 of 13 files at r5, 7 of 7 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @noaov1)
crates/blockifier/cairo_native line at r6 (raw file):
Previously, dorimedini-starkware wrote…
is this equal to the commit on main-v0.13.4?
yes it was changed and I change it back to the right commit
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @noaov1)
No description provided.