chore(blockifier, native_blockifier, starknet_batcher): remove visite… #2974
Conversation
|
This change is |
|
Artifacts upload workflows: |
There was a problem hiding this comment.
Python: https://reviewable.io/reviews/starkware-industries/starkware/36551
Reviewable status: 0 of 16 files reviewed, all discussions resolved (waiting on @meship-starkware and @noaov1)
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)
crates/blockifier/src/execution/entry_point_execution.rs line 105 at r1 (raw file):
// Instantiate Cairo runner. let proof_mode = false; let trace_enabled = false;
Why do we change the trace enable to false?
Code quote:
let trace_enabled = false;
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2 and @noaov1)
crates/blockifier/src/execution/entry_point_execution.rs line 105 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Why do we change the trace enable to false?
@liorgold2 changed it to true just for the visited pcs collection.
I'm reverting his change.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @noaov1)
…d PCS