Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(starknet_api): fix no item named warnings #2973

Merged
merged 1 commit into from
Dec 29, 2024
Merged

chore(starknet_api): fix no item named warnings #2973

merged 1 commit into from
Dec 29, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArniStarkware ArniStarkware marked this pull request as ready for review December 25, 2024 18:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

Artifacts upload workflows:

@ArniStarkware ArniStarkware force-pushed the arni/warnings/docstrings_item_not_found branch from 2dcadab to e58655f Compare December 26, 2024 11:15
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.918 ms 35.410 ms 35.979 ms]
change: [+2.0312% +3.6660% +5.3200%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
1 (1.00%) high mild
13 (13.00%) high severe

dorimedini-starkware
dorimedini-starkware approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @AvivYossef-starkware)

a discussion (no related file):
should this be over main-v0.13.4?

ArniStarkware
ArniStarkware commented Dec 29, 2024
View reviewed changes
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

should this be over main-v0.13.4?

Probably yes. Obviously, not critical.

@ArniStarkware ArniStarkware added this pull request to the merge queue Dec 29, 2024
Merged via the queue into main with commit 37d3b67 Dec 29, 2024
14 checks passed
ArniStarkware added a commit that referenced this pull request Dec 29, 2024
@ArniStarkware
chore(starknet_api): fix no item named warnings (#2973)
a8cd616
@ArniStarkware ArniStarkware mentioned this pull request Dec 29, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

@AvivYossef-starkware AvivYossef-starkware Awaiting requested review from AvivYossef-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArniStarkware @reviewable-StarkWare @dorimedini-starkware