fix(blockifier): bouncer_weights remove derives of add, addassign, sub. use 'checked' instead

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-19T14:48:59Z
• Started at 2024-12-19T15:15:23Z
• Started at 2024-12-19T15:20:55Z
• Started at 2024-12-22T10:01:10Z
• Started at 2024-12-22T10:15:34Z
• Started at 2024-12-23T13:00:44Z

[avivg-starkware]

• fix(blockifier): bouncer_weights remove derives of add, addassign, sub. use 'checked' instead #2835 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware, @noaov1, and @Yoni-Starkware)

---

crates/blockifier/src/bouncer.rs line 116 at r1 (raw file):

        *self = self.checked_add(other).expect("Addition overflow");
    }
}

you are making + operations behave like "checked_add_or_panic".
is this what we want?
I prefer to be explicit, how painful would it be to replace all?
(if it helps, you can derive the arithmetic traits in testing mode)

Code quote:

impl std::ops::Add for BouncerWeights {
    type Output = BouncerWeights;

    fn add(self, other: BouncerWeights) -> BouncerWeights {
        self.checked_add(other).expect("Addition overflow")
    }
}
impl std::ops::AddAssign for BouncerWeights {
    fn add_assign(&mut self, other: BouncerWeights) {
        *self = self.checked_add(other).expect("Addition overflow");
    }
}

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware)

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware, @noaov1, and @Yoni-Starkware)

---

crates/blockifier/src/bouncer.rs line 0 at r3 (raw file):

1. do we want checked or saturating?
2. if we want checked, please add more info in the expect message: (a) the text in the two cases should be different (easier to identify the source of panic) and (b) maybe also output the weights being added

[avivg-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

---

crates/blockifier/src/bouncer.rs line 116 at r1 (raw file):

Previously, dorimedini-starkware wrote…

you are making + operations behave like "checked_add_or_panic".
is this what we want?
I prefer to be explicit, how painful would it be to replace all?
(if it helps, you can derive the arithmetic traits in testing mode)

Done

---

crates/blockifier/src/bouncer.rs line at r3 (raw file):

Previously, dorimedini-starkware wrote…

1. do we want checked or saturating?
2. if we want checked, please add more info in the expect message: (a) the text in the two cases should be different (easier to identify the source of panic) and (b) maybe also output the weights being added

@Yoni-Starkware WDYT? i would assume checked, if overflow is something that shouldn't happen. but perhaps saturating is sufficient?

[Yoni-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @noaov1)

---

crates/blockifier/src/bouncer.rs line at r3 (raw file):

Previously, avivg-starkware wrote…

@Yoni-Starkware WDYT? i would assume checked, if overflow is something that shouldn't happen. but perhaps saturating is sufficient?

lgtm

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[avivg-starkware]

crates/blockifier/src/bouncer.rs line at r3 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

lgtm

@dorimedini-starkware how does the info I've added looks to you? should I change anything?

[dorimedini-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

---

crates/blockifier/src/bouncer.rs line at r3 (raw file):

Previously, avivg-starkware wrote…

@dorimedini-starkware how does the info I've added looks to you? should I change anything?

lgtm