Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): cairo version enum has only two variants #2352

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review November 28, 2024 15:01
Copy link
Collaborator Author

dorimedini-starkware commented Nov 28, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (11-28-test_blockifier_parametrize_feature_contracts_and_tests_by_runnable_type@d7f6041). Learn more about missing BASE report.

Additional details and impacted files
@@                                                Coverage Diff                                                @@
##             11-28-test_blockifier_parametrize_feature_contracts_and_tests_by_runnable_type    #2352   +/-   ##
=================================================================================================================
  Coverage                                                                                  ?   71.38%           
=================================================================================================================
  Files                                                                                     ?      102           
  Lines                                                                                     ?    13643           
  Branches                                                                                  ?    13643           
=================================================================================================================
  Hits                                                                                      ?     9739           
  Misses                                                                                    ?     3490           
  Partials                                                                                  ?      414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-test_blockifier_parametrize_feature_contracts_and_tests_by_runnable_type branch from 34d67ed to e3deb79 Compare December 1, 2024 14:27
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-refactor_blockifier_cairo_version_enum_has_only_two_variants branch from d084654 to 918a4bd Compare December 1, 2024 14:27
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-test_blockifier_parametrize_feature_contracts_and_tests_by_runnable_type branch from e3deb79 to 9e08bb3 Compare December 2, 2024 08:22
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-refactor_blockifier_cairo_version_enum_has_only_two_variants branch from 918a4bd to f1723f1 Compare December 2, 2024 08:22
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-test_blockifier_parametrize_feature_contracts_and_tests_by_runnable_type branch from 9e08bb3 to 43aab81 Compare December 2, 2024 08:50
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-refactor_blockifier_cairo_version_enum_has_only_two_variants branch from f1723f1 to 7d221eb Compare December 2, 2024 08:50
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-test_blockifier_parametrize_feature_contracts_and_tests_by_runnable_type branch from 43aab81 to 29115d1 Compare December 2, 2024 09:05
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-refactor_blockifier_cairo_version_enum_has_only_two_variants branch from 7d221eb to 405b81d Compare December 2, 2024 09:05
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-test_blockifier_parametrize_feature_contracts_and_tests_by_runnable_type branch from 29115d1 to 5e99ac5 Compare December 3, 2024 13:02
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-refactor_blockifier_cairo_version_enum_has_only_two_variants branch from 405b81d to 473521f Compare December 3, 2024 13:02
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-test_blockifier_parametrize_feature_contracts_and_tests_by_runnable_type branch from 5e99ac5 to d7f6041 Compare December 3, 2024 14:42
@dorimedini-starkware dorimedini-starkware force-pushed the 11-28-refactor_blockifier_cairo_version_enum_has_only_two_variants branch from 473521f to 3aa0833 Compare December 3, 2024 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants