Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

fix: invalid nonce format #2073

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

AvivYossef-starkware
Copy link
Collaborator

@AvivYossef-starkware AvivYossef-starkware commented Jul 10, 2024

commit-id:85a8a843


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


crates/blockifier/src/transaction/error_format_test.rs line 45 at r2 (raw file):

#[test]
fn test_invalid_nounce_format() {

typo

Suggestion:

invalid_nonce_format

@AvivYossef-starkware AvivYossef-starkware changed the base branch from spr/main-v0.13.2/776e06e7 to main-v0.13.2 July 14, 2024 10:20
@AvivYossef-starkware AvivYossef-starkware dismissed dorimedini-starkware’s stale review July 14, 2024 10:20

The base branch was changed.

@AvivYossef-starkware AvivYossef-starkware force-pushed the spr/main-v0.13.2/85a8a843 branch from 9c696b8 to 2b23e50 Compare July 14, 2024 10:20
@AvivYossef-starkware AvivYossef-starkware changed the base branch from main-v0.13.2 to spr/main-v0.13.2/776e06e7 July 14, 2024 10:20
@AvivYossef-starkware AvivYossef-starkware force-pushed the spr/main-v0.13.2/85a8a843 branch from 2b23e50 to 2b421bb Compare July 14, 2024 10:33
@AvivYossef-starkware AvivYossef-starkware force-pushed the spr/main-v0.13.2/776e06e7 branch 2 times, most recently from 0662936 to 48795ed Compare July 14, 2024 12:42
@AvivYossef-starkware AvivYossef-starkware force-pushed the spr/main-v0.13.2/85a8a843 branch from 2b421bb to 5c29d85 Compare July 14, 2024 12:42
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the spr/main-v0.13.2/776e06e7 branch from 48795ed to 20207a1 Compare July 14, 2024 13:19
@AvivYossef-starkware AvivYossef-starkware force-pushed the spr/main-v0.13.2/85a8a843 branch from 5c29d85 to b714a3d Compare July 14, 2024 13:19
@AvivYossef-starkware AvivYossef-starkware changed the base branch from spr/main-v0.13.2/776e06e7 to main-v0.13.2 July 14, 2024 13:58
@AvivYossef-starkware AvivYossef-starkware dismissed dorimedini-starkware’s stale review July 14, 2024 13:58

The base branch was changed.

@AvivYossef-starkware AvivYossef-starkware force-pushed the spr/main-v0.13.2/85a8a843 branch from b714a3d to d57f8db Compare July 14, 2024 19:41
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

commit-id:85a8a843
@AvivYossef-starkware AvivYossef-starkware dismissed dorimedini-starkware’s stale review July 15, 2024 08:28

The merge-base changed after approval.

@AvivYossef-starkware AvivYossef-starkware force-pushed the spr/main-v0.13.2/85a8a843 branch from d57f8db to d1ed414 Compare July 15, 2024 08:28
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware merged commit 8737930 into main-v0.13.2 Jul 15, 2024
28 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants