Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Solves #1168
As Starknet is now handled by the Ledger Nano S+ / X, we can create a signer that handle the private keys of this hardware wallet.
Usage related changes
After installing the Starknet Ledger DAPP in your Ledger, you can use the Ledger as signer.
The way to proceed depends of the type of connection, and of the framework used (see the guide for more details).
For example, in a Node script, using a Ledger Nano + :
Then you can use all usual methods of the Account class. When a signature is necessary, a message is displayed on the Ledger screen, and a manual validation is requested.
By this way, the private key of the account is never exposed.
The signature guide has been amended to include the Ledger Signer.
Development related changes
Nodes USB : https://github.com/PhilippeR26/starknet.js-workshop-typescript/blob/main/src/scripts/ledgerNano/5.testLedgerAccount.ts
Web USB : https://github.com/PhilippeR26/Starknet-Ledger-Wallet (the 3 types of signatures are tested)
Checklist: