Skip to content

Commit

Permalink
Merge branch 'matthewvon:master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewvon committed Jun 15, 2021
2 parents 236cb63 + 23ba170 commit 7fa1a75
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
12 changes: 9 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,17 @@ SNMP side channel for statistics retrieval from rocksdb
This project creates an SNMP agent based upon RFC 2741. The agent allows retrieval of rocksdb statistics without requiring the application that uses rocksdb to create any statistics infrastructure.

## Status
This is really old code. It dates from a time when I was playing with templates and other new toys.
It was used for monitoring Riak's leveldb, log files in production web environments, ArangoDB, and now Stardog.
WARNING: This is threaded code that is now using std::shared_ptr. std::shared_ptr is not generally thread safe.
Will update it with one of the 2 options available at C++11 level soon. C++20 std::shared_ptr is not
widely available within standard distributions at this time. There have been no known thread crashes due
to std::shared_ptr in this code.


This is really old code. It dates from a time when I was playing with templates and other new toys.
It was used for monitoring Riak's leveldb, log files in production web environments, ArangoDB, and now Stardog.
Some of the code is almost 20 years old and written for a RedHat 5 distribution.

The first release only supports rocksdb::Statistics as SNMP counters. Expect other properties,
The first release only supports rocksdb::Statistics as SNMP counters. Expect other properties,
including column family specific ones, to slowly creep into the code.

## Notes
Expand Down
5 changes: 4 additions & 1 deletion stats_table.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,10 @@ bool StatsTable::AddTable(rocksdb::DB * DBase,
{8, "rocksdb.live-sst-files-size"},
{9, "rocksdb.block-cache-capacity"},
{10,"rocksdb.block-cache-usage"},
{11,"rocksdb.block-cache-pinned-usage"}
{11,"rocksdb.block-cache-pinned-usage"},
{12,"rocksdb.table-cache-capacity"},
{13,"rocksdb.table-cache-usage"},
{14,"rocksdb.is-write-stopped"}
};

for (auto item : int_properties) {
Expand Down

0 comments on commit 7fa1a75

Please sign in to comment.