Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cython for Python 3.13 compatibility #359

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

CyanoKobalamyne
Copy link
Collaborator

@CyanoKobalamyne CyanoKobalamyne commented Oct 30, 2024

Currently, compiling the Python bindings with Python 3.13 results in the following error message:

 ../../../python/smt_switch/smt_switch_imp.pxi:536:7: error: use of undeclared identifier '_PyDict_SetItem_KnownHash'
  if (__Pyx_SetNameInClass(__pyx_t_3, __pyx_n_s_init, __pyx_t_7) < 0) __PYX_ERR(1, 536, __pyx_L1_error)
      ^
../../../python/smt_switch/smt_switch_imp.pxi:872:38: note: expanded from macro '__Pyx_SetNameInClass'
    (likely(PyDict_CheckExact(ns)) ? _PyDict_SetItem_KnownHash(ns, name, value, ((PyASCIIObject *) name)->hash) : PyObject_SetItem(ns, name, value))

This was fixed in cython/cython@fd96443, first included in version 3.0.5. We use an ancient version, I updated it to be at least this.

@CyanoKobalamyne CyanoKobalamyne merged commit 872acbf into main Oct 30, 2024
24 checks passed
@CyanoKobalamyne CyanoKobalamyne deleted the cython-py3.13-upgrade branch October 30, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants