Retrieve the package name from the DESCRIPTION file #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Yeah before merging it would be good to know if this solves it. Thanks! |
|
Thanks for the PR. Happy to check it. |
|
@wds15 were you able to check that this solved the issue you ran into? |
|
Sorry for not getting back earlier. So yes, this fix is great as it solves my issue. As a small improvement, I'd suggest to use this line of code to find out the package name:
this does not make the assumption that the Package name is in the first line of the DESCRIPTION file and should be more robust. |
|
Thanks @wds15, I agree with your solution, I've updated the PR to use that instead. |
|
Looks great to me like this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal fix for #129. I cannot reproduce the project with my packages (also the version of RBest on github doesn't cause the problem reported): @wds15 could you verify that it solves your problem?