Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overwriting of hash160, sha256, and sha512 mapping results #594

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

BowTiedWoo
Copy link
Collaborator

This PR addresses a bug where the results of the following expressions were being unintentionally overwritten:

  • (map hash160 (list 1 2 3))
  • (map sha256 (list 1 2 3))
  • (map sha512 (list 1 2 3))

The fix ensures that the outputs are correctly retained without overwriting.

Fixes: #590

+ add test cases for using map function with sha256, sha512 and hash160
@BowTiedWoo BowTiedWoo requested a review from Acaccia January 9, 2025 10:19
Copy link
Collaborator

@Acaccia Acaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BowTiedWoo BowTiedWoo enabled auto-merge January 9, 2025 10:40
@BowTiedWoo BowTiedWoo added this pull request to the merge queue Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (6a14610) to head (59eff39).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
- Coverage   85.52%   85.52%   -0.01%     
==========================================
  Files          46       46              
  Lines       24324    24344      +20     
  Branches    24324    24344      +20     
==========================================
+ Hits        20803    20819      +16     
- Misses       1672     1674       +2     
- Partials     1849     1851       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 1b79ee6 Jan 9, 2025
16 checks passed
@BowTiedWoo BowTiedWoo deleted the fix/map-sha256-overwritten-results branch January 9, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results overwrites in map of sha256
2 participants