-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-merge config #192
Conversation
name: auto-merge | ||
|
||
on: | ||
pull_request_target: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed or just here for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not fully sure if this is needed. I followed suggestion from @janisz . I guess, we can merge and test it :)
jobs: | ||
auto-merge: | ||
runs-on: ubuntu-latest | ||
if: github.actor == 'dependabot[bot]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like stackrox/stackrox uses a slightly different condition (adds auto-merge
flag to dependabot PRs). Do we want to do that here, too, to mimic that repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In stackrox we have label to exclude some PRs from automerge I think it's not required here the only problem with dependencies here is that upgrading them make break stackrox
It looks, like the auto-merge is being skipped: https://github.com/stackrox/go-grpc-http1/actions/runs/8643824443?pr=188 |
Fixes #183