Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-merge config #192

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add auto-merge config #192

merged 1 commit into from
Apr 11, 2024

Conversation

vikin91
Copy link
Contributor

@vikin91 vikin91 commented Apr 10, 2024

Fixes #183

@vikin91 vikin91 requested review from RTann and a team as code owners April 10, 2024 07:26
@vikin91 vikin91 requested a review from janisz April 10, 2024 08:25
name: auto-merge

on:
pull_request_target:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed or just here for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not fully sure if this is needed. I followed suggestion from @janisz . I guess, we can merge and test it :)

jobs:
auto-merge:
runs-on: ubuntu-latest
if: github.actor == 'dependabot[bot]'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like stackrox/stackrox uses a slightly different condition (adds auto-merge flag to dependabot PRs). Do we want to do that here, too, to mimic that repo?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In stackrox we have label to exclude some PRs from automerge I think it's not required here the only problem with dependencies here is that upgrading them make break stackrox

@vikin91 vikin91 merged commit 9bcc0cd into main Apr 11, 2024
1 check passed
@vikin91 vikin91 deleted the piotr/auto-merge branch April 11, 2024 08:31
@vikin91
Copy link
Contributor Author

vikin91 commented Apr 11, 2024

It looks, like the auto-merge is being skipped: https://github.com/stackrox/go-grpc-http1/actions/runs/8643824443?pr=188
Need to give it another look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have roxbot deal with dependabot updates
3 participants