Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /api/v1 routes to openapi spec #637

Closed
wants to merge 3 commits into from
Closed

Conversation

aponcedeleonch
Copy link
Contributor

It was missing an import

@alex-mcgovern
Copy link
Contributor

I think we need to take another look at this, I seem to be getting duplicate entries in the openapi json when I run this locally, and there's also this log line being included in the json file:

2025-01-17 13:26:06 [debug    ] Connecting to DB from path: /Users/alexmcgovern/src/codegate/codegate_volume/db/codegate.db
2025-01-17 13:26:06 [debug    ] Connecting to DB from path: /Users/alexmcgovern/src/codegate/codegate_volume/db/codegate.db

I think we should remove this debug log here:

logger.debug(f"Connecting to DB from path: {self._db_path}")

@alex-mcgovern
Copy link
Contributor

I have prepared an alternative PR where we mount the entire dashboard router under the v1 api router: #634

We can then just use the fastAPI app to build the openAPI schema, overall is a lot cleaner I think.

@alex-mcgovern
Copy link
Contributor

Closed in favor of #634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants