Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination for alerts table #104

Merged
merged 10 commits into from
Jan 17, 2025
Merged

feat: add pagination for alerts table #104

merged 10 commits into from
Jan 17, 2025

Conversation

kantord
Copy link
Member

@kantord kantord commented Jan 17, 2025

fixes #83

Implement simple client side pagination for the alerts table (plus adds a hook that can be used to implement similar stuff elsewhere)

For the video demonstration I set the page size very small to simplify the video:

Record_select-area_20250117150605.mp4

The pagination only has a prev and a next button, no ways to set page size, jump multiple pages, etc etc. I decided to keep it simple, because we don't really know yet how exactly the pagination will work in the BE. If BE has extra features, we can add them on the FE later as well

Copy link

stacklok-cloud-staging bot commented Jan 17, 2025

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 6c98391c:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Scoring details
Component Score
Package activity 7.9
Repository activity 7.2
User activity 8.6
Provenance verified_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 74
Number of git tags or releases 96
Versions matched to tags or releases 45

This package has been digitally signed using sigtore.

Source repository https://github.com/faker-js/faker
Cerificate Issuer CN=sigstore-intermediate,O=sigstore.dev
GitHub action workflow .github/workflows/publish-release.yml
Rekor (public ledger) entry https://search.sigstore.dev/?logIndex=162635182
Alternatives
Package Score Description
chance 0
json-schema-faker 0
casual 0

@coveralls
Copy link
Collaborator

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12832410853

Details

  • 40 of 42 (95.24%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 66.018%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/AlertsTable.tsx 26 28 92.86%
Totals Coverage Status
Change from base Build 12831773147: 0.4%
Covered Lines: 455
Relevant Lines: 611

💛 - Coveralls

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Scoring details
Component Score
Package activity 7.9
Repository activity 7.2
User activity 8.6
Provenance verified_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 74
Number of git tags or releases 96
Versions matched to tags or releases 45

This package has been digitally signed using sigtore.

Source repository https://github.com/faker-js/faker
Cerificate Issuer CN=sigstore-intermediate,O=sigstore.dev
GitHub action workflow .github/workflows/publish-release.yml
Rekor (public ledger) entry https://search.sigstore.dev/?logIndex=162635182
Alternatives
Package Score Description
chance 0
json-schema-faker 0
casual 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Scoring details
Component Score
Package activity 7.9
Repository activity 7.2
User activity 8.6
Provenance verified_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 74
Number of git tags or releases 96
Versions matched to tags or releases 45

This package has been digitally signed using sigtore.

Source repository https://github.com/faker-js/faker
Cerificate Issuer CN=sigstore-intermediate,O=sigstore.dev
GitHub action workflow .github/workflows/publish-release.yml
Rekor (public ledger) entry https://search.sigstore.dev/?logIndex=162635182
Alternatives
Package Score Description
chance 0
json-schema-faker 0
casual 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Scoring details
Component Score
Package activity 7.9
Repository activity 7.2
User activity 8.6
Provenance verified_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 74
Number of git tags or releases 96
Versions matched to tags or releases 45

This package has been digitally signed using sigtore.

Source repository https://github.com/faker-js/faker
Cerificate Issuer CN=sigstore-intermediate,O=sigstore.dev
GitHub action workflow .github/workflows/publish-release.yml
Rekor (public ledger) entry https://search.sigstore.dev/?logIndex=162635182
Alternatives
Package Score Description
chance 0
json-schema-faker 0
casual 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Scoring details
Component Score
Package activity 7.9
Repository activity 7.2
User activity 8.6
Provenance verified_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 74
Number of git tags or releases 96
Versions matched to tags or releases 45

This package has been digitally signed using sigtore.

Source repository https://github.com/faker-js/faker
Cerificate Issuer CN=sigstore-intermediate,O=sigstore.dev
GitHub action workflow .github/workflows/publish-release.yml
Rekor (public ledger) entry https://search.sigstore.dev/?logIndex=162635182
Alternatives
Package Score Description
chance 0
json-schema-faker 0
casual 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Scoring details
Component Score
Package activity 7.9
Repository activity 7.2
User activity 8.6
Provenance verified_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 74
Number of git tags or releases 96
Versions matched to tags or releases 45

This package has been digitally signed using sigtore.

Source repository https://github.com/faker-js/faker
Cerificate Issuer CN=sigstore-intermediate,O=sigstore.dev
GitHub action workflow .github/workflows/publish-release.yml
Rekor (public ledger) entry https://search.sigstore.dev/?logIndex=162635182
Alternatives
Package Score Description
chance 0
json-schema-faker 0
casual 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Scoring details
Component Score
Package activity 7.9
Repository activity 7.2
User activity 8.6
Provenance verified_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 74
Number of git tags or releases 96
Versions matched to tags or releases 45

This package has been digitally signed using sigtore.

Source repository https://github.com/faker-js/faker
Cerificate Issuer CN=sigstore-intermediate,O=sigstore.dev
GitHub action workflow .github/workflows/publish-release.yml
Rekor (public ledger) entry https://search.sigstore.dev/?logIndex=162635182
Alternatives
Package Score Description
chance 0
json-schema-faker 0
casual 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Scoring details
Component Score
Package activity 7.9
Repository activity 7.2
User activity 8.6
Provenance verified_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 74
Number of git tags or releases 96
Versions matched to tags or releases 45

This package has been digitally signed using sigtore.

Source repository https://github.com/faker-js/faker
Cerificate Issuer CN=sigstore-intermediate,O=sigstore.dev
GitHub action workflow .github/workflows/publish-release.yml
Rekor (public ledger) entry https://search.sigstore.dev/?logIndex=162635182
Alternatives
Package Score Description
chance 0
json-schema-faker 0
casual 0

@kantord kantord changed the title Add pagination feat: add pagination for alerts table Jan 17, 2025
Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Scoring details
Component Score
Package activity 7.9
Repository activity 7.2
User activity 8.6
Provenance verified_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 74
Number of git tags or releases 96
Versions matched to tags or releases 45

This package has been digitally signed using sigtore.

Source repository https://github.com/faker-js/faker
Cerificate Issuer CN=sigstore-intermediate,O=sigstore.dev
GitHub action workflow .github/workflows/publish-release.yml
Rekor (public ledger) entry https://search.sigstore.dev/?logIndex=162635182
Alternatives
Package Score Description
chance 0
json-schema-faker 0
casual 0

@kantord kantord marked this pull request as ready for review January 17, 2025 14:22
Copy link
Collaborator

@peppescg peppescg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kantord kantord enabled auto-merge (squash) January 17, 2025 15:52
Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @faker-js/faker

Trusty Score: 0

Scoring details
Component Score
Package activity 7.9
Repository activity 7.2
User activity 8.6
Provenance verified_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 74
Number of git tags or releases 96
Versions matched to tags or releases 45

This package has been digitally signed using sigtore.

Source repository https://github.com/faker-js/faker
Cerificate Issuer CN=sigstore-intermediate,O=sigstore.dev
GitHub action workflow .github/workflows/publish-release.yml
Rekor (public ledger) entry https://search.sigstore.dev/?logIndex=162635182
Alternatives
Package Score Description
chance 0
json-schema-faker 0
casual 0

@kantord kantord merged commit a38e2cd into main Jan 17, 2025
7 checks passed
@kantord kantord deleted the add-pagination branch January 17, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination for alerts table and prompts
3 participants