2023.1: Update to Rocky 9.3 based kolla images #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two upgrade test jobs: Ubuntu Jammy OVS and Rocky 9 OVN. These jobs reuse the existing aio reusable workflow, which has a new 'upgrade' input parameter. When testing an upgrade, the previous release is first deployed, then the aio is upgraded to the current release before running RefStack tests.
This will make it easier to automate various tasks.
We no longer require it since Ironic dropped the iscsi deploy driver.
No more forgotten image promotions!
Use the new kolla-images.py script to automatically define tag variables in globals.yml based on the tags that are defined in kolla_image_tags.
zed: yoga merge
The previous tag was not in Ark, but this one is present.
The failing case was the haproxy image used by the neutron_tls_proxy container, if a tag is defined for the 'neutron' prefix but not 'haproxy'.
Co-authored-by: Alex-Welsh <[email protected]>
CI: Add upgrade tests
zed: automate Kolla Ansible tag variable definitions
```
TASK [stackhpc.pulp.pulp_repository : include_tasks] ************************************************************************************************************************
Friday 02 February 2024 18:54:16 +0100 (0:00:00.189) 0:00:00.189 *******
fatal: [localhost]: FAILED! =>
msg: |-
The conditional check 'pulp_repository_container_repos | length > 0' failed. The error was: error while evaluating conditional (pulp_repository_container_repos | length
> 0): {{ stackhpc_pulp_repository_container_repos }}: {{ (stackhpc_pulp_repository_container_repos_kolla +
stackhpc_pulp_repository_container_repos_ceph +
stackhpc_pulp_repository_container_repos_hashicorp) | selectattr('required') }}: {%- set repos = [] -%} {%- for image in stackhpc_pulp_images_kolla_filtered -%} {%-
if image not in stackhpc_kolla_unbuildable_images[kolla_base_distro]-%} {%- set image_repo = kolla_docker_namespace ~ "/" ~ image -%} {%- set repo = {"name": image_repo} -%}
{%- set _ = repos.append(stackhpc_pulp_repository_container_repos_kolla_common | combine(repo)) -%} {%- endif -%} {%- endfor -%} {{ repos }}: 'dict object' has no attribute
'rocky'
The error appears to be in '/home/stack/kayobe-env-zed/src/kayobe-config/etc/kayobe/ansible/collections/ansible_collections/stackhpc/pulp/roles/pulp_repository/tasks/mai
n.yml': line 2, column 3, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
---
- include_tasks: container.yml
^ here
```
These have been rebuilt using Rocky 9.3 snapshots. Builds: - neutron: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/7757690528 - others: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/7754959464
jovial
force-pushed
the
feature/2023.1/kolla-rocky-9.3
branch
from
82f5e4a to
806f838
Compare
```
TASK [Query images and tags] ***************************************************
Friday 02 February 2024 20:39:16 +0000 (0:00:01.453) 0:00:01.529 *******
fatal: [localhost]: FAILED! => changed=false
cmd:
- /stack/kayobe-automation-env/src/kayobe-config/etc/kayobe/../../tools/kolla-images.py
- list-tags
delta: '0:00:00.324461'
end: '2024-02-02 20:39:17.748038'
msg: non-zero return code
rc: 1
start: '2024-02-02 20:39:17.423577'
stderr: |-
Traceback (most recent call last):
File "/stack/kayobe-automation-env/src/kayobe-config/etc/kayobe/../../tools/kolla-images.py", line 372, in <module>
main()
File "/stack/kayobe-automation-env/src/kayobe-config/etc/kayobe/../../tools/kolla-images.py", line 364, in main
list_tags(base_distros, kolla_image_tags)
File "/stack/kayobe-automation-env/src/kayobe-config/etc/kayobe/../../tools/kolla-images.py", line 328, in list_tags
image_tags = get_tags(base_distros, kolla_image_tags)
File "/stack/kayobe-automation-env/src/kayobe-config/etc/kayobe/../../tools/kolla-images.py", line 199, in get_tags
tag = get_tag(kolla_image_tags, base_distro, container)
File "/stack/kayobe-automation-env/src/kayobe-config/etc/kayobe/../../tools/kolla-images.py", line 187, in get_tag
return get_parent_tag(kolla_image_tags, base_distro, container)
File "/stack/kayobe-automation-env/src/kayobe-config/etc/kayobe/../../tools/kolla-images.py", line 178, in get_parent_tag
return kolla_image_tags[parent_tag_name][base_distro]
KeyError: 'rocky-9'
stderr_lines: <omitted>
stdout: ''
stdout_lines: <omitted>
```
…ync/zed-into-2023.1
This reverts commit d2424a9.
|
Seems like I need to build letsencrypt and haproxy-ssh |
…re/2023.1/kolla-rocky-9.3
|
Building haproxy-ssh and letsencrypt images here: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/7782531629 |
markgoddard
previously approved these changes
Feb 6, 2024
jovial
dismissed
markgoddard’s stale review
The merge-base changed after approval.
markgoddard
approved these changes
Feb 6, 2024
markgoddard
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've optimistically added this on top of: #909