Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add upgrade tests #869

Merged
merged 2 commits into from
Jan 31, 2024
Merged

CI: Add upgrade tests #869

merged 2 commits into from
Jan 31, 2024

Conversation

markgoddard
Copy link
Contributor

@markgoddard markgoddard commented Jan 12, 2024

Adds two upgrade test jobs: Ubuntu Jammy OVS and Rocky 9 OVN.

These jobs reuse the existing aio reusable workflow, which has a new 'upgrade' input parameter. When testing an upgrade, the previous release is first deployed, then the aio is upgraded to the current release before running RefStack tests.

@markgoddard markgoddard self-assigned this Jan 12, 2024
@markgoddard markgoddard force-pushed the zed-upgrade-ci-test branch 15 times, most recently from 2ad5b7f to 7995bf1 Compare January 17, 2024 08:49
Adds two upgrade test jobs: Ubuntu Jammy OVS and Rocky 9 OVN.

These jobs reuse the existing aio reusable workflow, which has a new
'upgrade' input parameter. When testing an upgrade, the previous release
is first deployed, then the aio is upgraded to the current release
before running RefStack tests.
@markgoddard markgoddard changed the title WIP: CI: Add upgrade tests CI: Add upgrade tests Jan 17, 2024
@markgoddard markgoddard marked this pull request as ready for review January 17, 2024 13:16
@markgoddard markgoddard requested a review from a team as a code owner January 17, 2024 13:16
@MoteHue
Copy link
Contributor

MoteHue commented Jan 18, 2024

Is it SMS capacity limits that are motivating just adding two tests? I'm wondering how big of an issue it would be to not cover OVN/OVS on both distributions. We do have customers on OVN Ubuntu for example, so issues could slip through the cracks here.

@markgoddard
Copy link
Contributor Author

Is it SMS capacity limits that are motivating just adding two tests? I'm wondering how big of an issue it would be to not cover OVN/OVS on both distributions. We do have customers on OVN Ubuntu for example, so issues could slip through the cracks here.

Correct - ideally we would cover all cases. There may be an argument for nightly runs covering all combinations, if we can report the results somewhere sensible.

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits otherwise LGTM

.github/workflows/stackhpc-all-in-one.yml Outdated Show resolved Hide resolved
.github/workflows/stackhpc-all-in-one.yml Outdated Show resolved Hide resolved
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth an update to release train so it's a required check

@markgoddard markgoddard merged commit 85b1e3c into stackhpc/zed Jan 31, 2024
11 checks passed
@markgoddard markgoddard deleted the zed-upgrade-ci-test branch January 31, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants