Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Growroot Playbook #770

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix Growroot Playbook #770

merged 2 commits into from
Nov 10, 2023

Conversation

technowhizz
Copy link
Contributor

Fixes an issue with the growroot playbook where disks such as 'sdp' would become 'sd' due to the removal of the trailing 'p' when dealing with nvme devices.

@technowhizz technowhizz self-assigned this Nov 10, 2023
@technowhizz technowhizz requested a review from a team as a code owner November 10, 2023 10:27
@technowhizz technowhizz merged commit 5c7e56b into stackhpc/yoga Nov 10, 2023
@technowhizz technowhizz deleted the fix-growroot branch November 10, 2023 14:40
@mnasiadka
Copy link
Member

This broke SW raid cases:

TASK [Grow partition] *****************************************************************************************************************************************************************************************************************************************
Thursday 16 November 2023 12:26:58 +0000 (0:00:00.021) 0:00:01.044 *****
fatal: [dma-compute-03]: FAILED! => changed=true
cmd:

  • growpart
  • /dev/md126p
  • '3'
    delta: '0:00:00.003015'
    end: '2023-11-16 12:28:11.971067'
    failed_when_result: true
    msg: non-zero return code
    rc: 2
    start: '2023-11-16 12:28:11.968052'
    stderr: ''
    stderr_lines:
    stdout: 'FAILED: /dev/md126p: does not exist'
    stdout_lines:

@markgoddard
Copy link
Contributor

This broke SW raid cases:

TASK [Grow partition] ***************************************************************************************************************************************************************************************************************************************** Thursday 16 November 2023 12:26:58 +0000 (0:00:00.021) 0:00:01.044 ***** fatal: [dma-compute-03]: FAILED! => changed=true cmd:

  • growpart
  • /dev/md126p
  • '3'
    delta: '0:00:00.003015'
    end: '2023-11-16 12:28:11.971067'
    failed_when_result: true
    msg: non-zero return code
    rc: 2
    start: '2023-11-16 12:28:11.968052'
    stderr: ''
    stderr_lines:
    stdout: 'FAILED: /dev/md126p: does not exist'
    stdout_lines:

I guess the rule is if the base device name ends in a number then the partition is separated with a 'p'.

@markgoddard
Copy link
Contributor

This broke SW raid cases:
TASK [Grow partition] ***************************************************************************************************************************************************************************************************************************************** Thursday 16 November 2023 12:26:58 +0000 (0:00:00.021) 0:00:01.044 ***** fatal: [dma-compute-03]: FAILED! => changed=true cmd:

  • growpart
  • /dev/md126p
  • '3'
    delta: '0:00:00.003015'
    end: '2023-11-16 12:28:11.971067'
    failed_when_result: true
    msg: non-zero return code
    rc: 2
    start: '2023-11-16 12:28:11.968052'
    stderr: ''
    stderr_lines:
    stdout: 'FAILED: /dev/md126p: does not exist'
    stdout_lines:

I guess the rule is if the base device name ends in a number then the partition is separated with a 'p'.

If so we could match on this re: [a-z0-9]+[0-9]+p[0-9]+

jovial added a commit that referenced this pull request Dec 6, 2023
mnasiadka added a commit that referenced this pull request Sep 12, 2024
* Fix growroot when using software raid

Using @markgoddard's suggestion from: #770 (comment)

* Add a release note

* Update releasenotes/notes/fixes-growroot-for-software-raid-3852bdea5415a0be.yaml

Co-authored-by: Alex-Welsh <[email protected]>
Co-authored-by: Michał Nasiadka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants