Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh all tags #720

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Refresh all tags #720

merged 4 commits into from
Oct 27, 2023

Conversation

Alex-Welsh
Copy link
Member

Currently only package repo tags have been updated. I will soon build container images from this branch and update this PR. Marking as draft until then.

Alex-Welsh and others added 3 commits October 20, 2023 15:48
@Alex-Welsh
Refresh all package repository tags
990943b
@mnasiadka @Alex-Welsh
Fix dnf repo file names in Rocky 9
81ebaea 
Rocky 9 uses /etc/yum.repos.d/rocky.repo and rocky-extras.repo
and the current config creates duplicate entries.
@m-bull
Bump package repos to latest available on Ark
a3c3f95
@Alex-Welsh Alex-Welsh marked this pull request as ready for review October 25, 2023 09:18
@Alex-Welsh Alex-Welsh requested a review from a team as a code owner October 25, 2023 09:18
@mnasiadka
Copy link
Member

Do we need a reno here?

@Alex-Welsh
Copy link
Member Author

Do we need a reno here?

Done

mnasiadka
mnasiadka previously approved these changes Oct 25, 2023
View reviewed changes
@Alex-Welsh
Copy link
Member Author

Sync is here: https://github.com/stackhpc/stackhpc-release-train/actions/runs/6640490429
I'll promote once CI passes

@Alex-Welsh Alex-Welsh force-pushed the bump-tags branch 2 times, most recently from 6e407f2 to 0929dfb Compare October 26, 2023 16:06
@jovial
Copy link
Contributor

jovial commented Oct 27, 2023 •
edited
Loading

Does:

│ 
│   with data.openstack_images_image_v2.image[0],
│   on vm.tf line 40, in data "openstack_images_image_v2" "image":
│   40: data "openstack_images_image_v2" "image" {
│ 
╵

mean that the overcloud host image wasn't uploaded to SMS lab? I can't see us bumping those images in this PR, so I assume it was broken on stackhpc/yoga already.

@Alex-Welsh Alex-Welsh merged commit fdbfbfc into stackhpc/yoga Oct 27, 2023
@Alex-Welsh Alex-Welsh deleted the bump-tags branch October 27, 2023 13:38
@Alex-Welsh
Copy link
Member Author

Does:

│ 
│   with data.openstack_images_image_v2.image[0],
│   on vm.tf line 40, in data "openstack_images_image_v2" "image":
│   40: data "openstack_images_image_v2" "image" {
│ 
╵

mean that the overcloud host image wasn't uploaded to SMS lab? I can't see us bumping those images in this PR, so I assume it was broken on stackhpc/yoga already.

It's an error due to a backport, there's a slack thread here

@Alex-Welsh
Copy link
Member Author

Does:

│ 
│   with data.openstack_images_image_v2.image[0],
│   on vm.tf line 40, in data "openstack_images_image_v2" "image":
│   40: data "openstack_images_image_v2" "image" {
│ 
╵

mean that the overcloud host image wasn't uploaded to SMS lab? I can't see us bumping those images in this PR, so I assume it was broken on stackhpc/yoga already.

It's an error due to a backport, there's a slack thread here

Ah, maybe not. The errors look a bit different

@markgoddard
Copy link
Contributor

Right - that issue should now be fixed.

markgoddard
markgoddard reviewed Oct 27, 2023
View reviewed changes
etc/kayobe/kolla/globals.yml
Comment on lines -66 to -67
glance_tls_proxy_tag: "{% raw %}{{ haproxy_tag | default(openstack_tag) }}{% endraw %}"
neutron_tls_proxy_tag: "{% raw %}{{ haproxy_tag | default(openstack_tag) }}{% endraw %}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to keep these because it's not obvious that you need them if setting haproxy_tag. Could include a comment to that effect.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. I've set up a PR for fixes here where I'll make that change

etc/kayobe/kolla/globals.yml

# Live-migration is broken from qemu-kvm-6.2.0-20.module_el8.7.0+1218+f626c2ff to qemu-kvm-6.2.0-39.module_el8+669+76cc32af
# with signature: `Missing section footer for 0000:00:01.3/piix4_pm`. Test nova carefully before bumping.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this comment still applies then we still need the old nova_libvirt tag. If not then the comment can be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes PR: #723

etc/kayobe/kolla/globals.yml Show resolved Hide resolved
@jovial jovial mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard left review comments

@jovial jovial jovial approved these changes

@mnasiadka mnasiadka mnasiadka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Alex-Welsh @mnasiadka @jovial @markgoddard @m-bull