-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom sca policies remote checks #717
Conversation
The config option to allow for remote commands needs to be set on the agents, not the manager. This fixes many benchmarks being makred as not applicable.
f678a97
to
f49a774
Compare
Reno? |
Previous PR for context: #711 |
The original PR has a reno, not sure if this also needs one as it just follows up on that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, I guess we should have a reno, but the chance of someone:
a) using this feature, and
b) using a commit in between when the feature landed and this bugfix
is low, so I guess we could let it slide.
92ebe2c
to
25d216c
Compare
I'll do this, it would be good to get the actual fix in sooner |
ff779ca
to
a801224
Compare
The config option to allow for remote commands needs to be set on the agents, not the manager. This fixes many benchmarks being makred as not applicable.