Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom sca policies remote checks #717

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Oct 19, 2023

The config option to allow for remote commands needs to be set on the agents, not the manager. This fixes many benchmarks being makred as not applicable.

@MoteHue MoteHue requested a review from jovial October 19, 2023 09:27
@MoteHue MoteHue requested a review from a team as a code owner October 19, 2023 09:27
The config option to allow for remote commands needs to be set
on the agents, not the manager. This fixes many benchmarks being
makred as not applicable.
@MoteHue MoteHue force-pushed the wazuh-remote-commands-fix branch from f678a97 to f49a774 Compare October 20, 2023 10:28
@Alex-Welsh
Copy link
Contributor

Reno?

@MoteHue
Copy link
Contributor Author

MoteHue commented Oct 20, 2023

Previous PR for context: #711

@MoteHue
Copy link
Contributor Author

MoteHue commented Oct 20, 2023

Reno?

The original PR has a reno, not sure if this also needs one as it just follows up on that?

etc/kayobe/ansible/wazuh-manager.yml Outdated Show resolved Hide resolved
etc/kayobe/ansible/wazuh-manager.yml Outdated Show resolved Hide resolved
etc/kayobe/ansible/wazuh-manager.yml Outdated Show resolved Hide resolved
jovial
jovial previously approved these changes Oct 27, 2023
Copy link
Contributor

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, I guess we should have a reno, but the chance of someone:
a) using this feature, and
b) using a commit in between when the feature landed and this bugfix
is low, so I guess we could let it slide.

etc/kayobe/ansible/wazuh-manager.yml Outdated Show resolved Hide resolved
etc/kayobe/ansible/wazuh-manager.yml Outdated Show resolved Hide resolved
@MoteHue MoteHue force-pushed the wazuh-remote-commands-fix branch from 92ebe2c to 25d216c Compare November 6, 2023 13:54
etc/kayobe/ansible/wazuh-manager.yml Outdated Show resolved Hide resolved
etc/kayobe/ansible/wazuh-manager.yml Show resolved Hide resolved
etc/kayobe/ansible/wazuh-manager.yml Outdated Show resolved Hide resolved
@MoteHue
Copy link
Contributor Author

MoteHue commented Nov 7, 2023

revert to using become and remove it in a separate PR

I'll do this, it would be good to get the actual fix in sooner

@MoteHue MoteHue force-pushed the wazuh-remote-commands-fix branch from ff779ca to a801224 Compare November 7, 2023 11:39
@markgoddard markgoddard merged commit bbaf7bb into stackhpc/yoga Nov 7, 2023
@markgoddard markgoddard deleted the wazuh-remote-commands-fix branch November 7, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants