Fix zed host image build workflow #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kayobe-automation seems to need this patch to work for zed. |
Alex-Welsh
force-pushed
the
zed-fix-ci
branch
7 times, most recently
from
da9a05e to
21a866f
Compare
Alex-Welsh
force-pushed
the
zed-fix-ci
branch
9 times, most recently
from
c9d1983 to
6ec1af8
Compare
Merged
|
How much of this is still required? |
|
I'm not sure. The host image build workflow changes are probably still required. I'll test it soon |
Alex-Welsh
force-pushed
the
zed-fix-ci
branch
from
6ec1af8 to
5705fef
Compare
Alex-Welsh
force-pushed
the
zed-fix-ci
branch
from
5705fef to
8721f47
Compare
Alex-Welsh
force-pushed
the
zed-fix-ci
branch
5 times, most recently
from
86eed3b to
13d8771
Compare
Alex-Welsh
force-pushed
the
zed-fix-ci
branch
from
13d8771 to
3af6f35
Compare
Alex-Welsh
force-pushed
the
zed-fix-ci
branch
from
3af6f35 to
121005e
Compare
markgoddard
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Should these fixes go back to yoga?
There was a problem hiding this comment.
It's running fine without them, probably because it uses the old CS8 runners
markgoddard
reviewed
Oct 20, 2023
| with: | ||
| path: src/kayobe-config | ||
|
|
||
| - name: Determine OpenStack release | ||
| id: openstack_release | ||
| run: | | ||
| BRANCH=$(awk -F'=' '/defaultbranch/ {print $2}' .gitreview) | ||
| BRANCH=$(awk -F'=' '/defaultbranch/ {print $2}' src/kayobe-config/.gitreview) |
There was a problem hiding this comment.
Isn't this a bug fix that would apply to yoga too?
There was a problem hiding this comment.
Merged, but please backport this fix if necessary.
markgoddard
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.