Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DWPD to Hardware Overview dashboard #621

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Add DWPD to Hardware Overview dashboard #621

merged 5 commits into from
Nov 17, 2023

Conversation

technowhizz
Copy link
Contributor

Adds a panel in the Hardware Overview dashboard to show DWPD (Drive writes per day) for NVMEs. This is calculated by dividing the total bytes written in the past 24 hours by the drive capacity.

Adds the DWPD (Drive Writes Per Day) to the Hardware Overview dashboard
in Grafana. This is useful for monitoring the wear on NVMEs.
@technowhizz technowhizz requested a review from a team as a code owner September 6, 2023 15:39
@technowhizz technowhizz self-assigned this Sep 6, 2023
oneswig
oneswig previously approved these changes Sep 22, 2023
Copy link
Member

@oneswig oneswig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see this

Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to add the following before finishing this task:

  • Short documentation section to be added explaining the limitations (only nvme supported) and how to customise the dashboard to remove the plot on systems without supported drives.
  • Alert to be added, as noted in https://stackhpc.atlassian.net/browse/INFRA-395

@Alex-Welsh
Copy link
Contributor

@technowhizz is this still WIP? would it be better to convert to draft for now?

@technowhizz
Copy link
Contributor Author

@Alex-Welsh Nope, its waiting to be merged :)

@Alex-Welsh
Copy link
Contributor

@Alex-Welsh Nope, its waiting to be merged :)

Might want to poke some potential reviewers then

dougszumski
dougszumski previously approved these changes Oct 23, 2023
Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @technowhizz.

releasenotes/notes/dwpd-6b9fb0c8d6d3a570.yaml Show resolved Hide resolved
@technowhizz
Copy link
Contributor Author

@oneswig bumped up the alert durations as discussed

@technowhizz technowhizz merged commit 533ee57 into stackhpc/yoga Nov 17, 2023
15 checks passed
@technowhizz technowhizz deleted the DWPD branch November 17, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants