Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nodes to appear in more than one group/partition #174

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

jovial
Copy link
Contributor

@jovial jovial commented Nov 20, 2024

Prior to this change slurmctld would fail to start if adding nodes to multiple partitions e.g:

openhpc_slurm_partitions:
    - name: allnodes
      groups:
        - name: alfa
        - name: beta
      partition_params:
        Priority: 50
      default: YES
    - name: alfa
      partition_params:
        Priority: 100
    - name: bravo
      partition_params:
        Priority: 100

This change tracks all nodes that already have a NodeName entry and will not add again.

@jovial jovial requested a review from a team as a code owner November 20, 2024 13:58
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the main README.md be modified please to remove the entry:

  • Nodes may not appear in more than one group.

Happy to merge then, CI passed on rerunning one failed task.

Thank you this is very useful!

@sjpb sjpb changed the title Fix duplication of nodes in NodeName Allow nodes to appear in more than one group/partition Nov 21, 2024
@jianguo-ukaea
Copy link
Contributor

Can the main README.md be modified please to remove the entry:

  • Nodes may not appear in more than one group.

Happy to merge then, CI passed on rerunning one failed task.

Thank you this is very useful!

This has been done and the workflow awaiting approval

@sjpb sjpb self-requested a review November 26, 2024 10:41
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 31017d2 into stackhpc:master Nov 26, 2024
34 checks passed
@sjpb
Copy link
Collaborator

sjpb commented Nov 26, 2024

@jianguo-ukaea thank you this is now merged/released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants