Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use generic variables when registry is shared #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jackhodgkiss
Copy link
Collaborator

No description provided.

@jackhodgkiss jackhodgkiss marked this pull request as ready for review June 17, 2024 20:29
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner June 17, 2024 20:29
Copy link

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we agreed to always use specific variables and secrets when using multiple environments to make the docs simpler.

@jackhodgkiss
Copy link
Collaborator Author

I thought we agreed to always use specific variables and secrets when using multiple environments to make the docs simpler.

I did have a good reason for wanting to make this change but I can't remember. Let me compare output and I will update the commit with motivation as to why I made this change half a year ago.

@markgoddard
Copy link

I thought we agreed to always use specific variables and secrets when using multiple environments to make the docs simpler.

I did have a good reason for wanting to make this change but I can't remember. Let me compare output and I will update the commit with motivation as to why I made this change half a year ago.

A lesson in the benefit of detailed commit messages. For others and future you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants