Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn when using .svg in meta.image #377

Merged
merged 5 commits into from
Nov 25, 2024
Merged

fix: warn when using .svg in meta.image #377

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9174bd4
warning when using SVG open graph image
eric-burel Oct 16, 2024
8fe131a
Merge branch 'main' into doc-meta
AriPerkkio Oct 18, 2024
4e79398
chore: update docs
AriPerkkio Oct 18, 2024
ebd26f6
Merge branch 'main' into doc-meta
AriPerkkio Oct 18, 2024
e0559c3
Merge branch 'main' into doc-meta
AriPerkkio Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/astro/src/default/components/MetaTags.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ if (imageUrl?.startsWith('/') || imageUrl?.startsWith('.')) {
}

imageUrl ??= readLogoFile('logo', true);
if (imageUrl?.endsWith('.svg')) {
console.warn(`Using a SVG open graph image "${imageUrl}". This is not supported by most social platforms.
You should rather set "meta.image" to a raster image (PNG, WEBP).`);
}
AriPerkkio marked this conversation as resolved.
Show resolved Hide resolved
---

<meta charset="UTF-8" />
Expand Down