Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate stackable_operator::logging::initialize_logging() #950

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: deprecate stackable_operator::logging::initialize_logging() #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f135cae
chore: deprecate stackable_operator::logging::initialize_logging()
xeniape Jan 27, 2025
2c551ee
adjust changelog
xeniape Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/stackable-operator/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Changed

- Deprecate `stackable_operator::logging::initialize_logging()`. It's recommended to use `stackable-telemetry` instead ([#950]).

[#950]: https://github.com/stackabletech/operator-rs/pull/950

## [0.84.1] - 2025-01-22

### Fixed
Expand Down
2 changes: 2 additions & 0 deletions crates/stackable-operator/src/logging/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ impl Default for TracingTarget {
///
/// Log output can be copied to a file by setting `{env}_DIRECTORY` (e.g. `FOOBAR_OPERATOR_DIRECTORY`)
/// to a directory path. This file will be rotated regularly.
#[deprecated(note = "Use stackable-telemetry instead, use OTLP instead of Jaeger protocol")]
pub fn initialize_logging(env: &str, app_name: &str, tracing_target: TracingTarget) {
let filter = match EnvFilter::try_from_env(env) {
Ok(env_filter) => env_filter,
Expand Down Expand Up @@ -94,6 +95,7 @@ mod tests {
// NOT_SET=debug cargo test default_tracing -- --nocapture
// to see them all.
#[test]
#[allow(deprecated)]
fn default_tracing_level_is_set_to_info() {
super::initialize_logging("NOT_SET", "test", TracingTarget::None);

Expand Down
Loading