Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stackable-telemetry): Add RollingFileAppender #933

Merged
merged 13 commits into from
Jan 22, 2025
Merged

feat(stackable-telemetry): Add RollingFileAppender #933

merged 13 commits into from
Jan 22, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Dec 19, 2024 •
edited by NickLarsenNZ
Loading

Description

Part of stackabletech/issues#639. Adds the RollingFileAppender to the stackable-telemetry crate.

Add RollingFileAppender to stackable-telemetry (as was done in #814).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@xeniape xeniape self-assigned this Dec 19, 2024
@xeniape xeniape mentioned this pull request Dec 19, 2024
Open
16 tasks
Techassi
Techassi requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core change looks good, but I left a few comments / ideas on how we should design the API interface.

crates/stackable-telemetry/CHANGELOG.md Outdated Show resolved Hide resolved
crates/stackable-telemetry/src/tracing/mod.rs Outdated Show resolved Hide resolved
crates/stackable-telemetry/src/tracing/settings/file_log.rs Outdated Show resolved Hide resolved
crates/stackable-telemetry/src/tracing/settings/file_log.rs Outdated Show resolved Hide resolved
crates/stackable-telemetry/src/tracing/settings/mod.rs Outdated Show resolved Hide resolved
NickLarsenNZ
NickLarsenNZ reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xeniape. Just a couple of comments.

crates/stackable-telemetry/src/tracing/mod.rs Outdated Show resolved Hide resolved
crates/stackable-telemetry/src/tracing/mod.rs Show resolved Hide resolved
crates/stackable-telemetry/src/tracing/settings/file_log.rs Outdated Show resolved Hide resolved
@xeniape
Copy link
Member Author

xeniape commented Jan 16, 2025

Thanks for all the feedback! Adjusted everything in bfe89a7

@Techassi Techassi changed the title feat: add RollingFileAppender to stackable-telemetry feat(stackable-telemetry): Add RollingFileAppender Jan 16, 2025
@xeniape xeniape requested a review from Techassi January 17, 2025 09:22
@xeniape xeniape requested a review from Techassi January 20, 2025 10:07
@xeniape xeniape added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 4c2bfaa Jan 22, 2025
10 checks passed
@xeniape xeniape deleted the feat/add-rolling-file-appender branch January 22, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

@NickLarsenNZ NickLarsenNZ Awaiting requested review from NickLarsenNZ

Assignees

@xeniape xeniape

Labels
None yet
Projects
Stackable Engineering
Status: Development: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xeniape @NickLarsenNZ @Techassi