Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add jvmArgumentOverrides as well as common code #931

Merged
merged 26 commits into from
Jan 16, 2025
Merged

feat!: Add jvmArgumentOverrides as well as common code #931

merged 26 commits into from
Jan 16, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Dec 13, 2024 •
edited by maltesander
Loading

Description

Part of stackabletech/issues#584

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer mentioned this pull request Dec 13, 2024
Open
@sbernauer sbernauer changed the title feat!: Add optional jvmArgumentOverrides as well as common code feat!: Add jvmArgumentOverrides as well as common code Jan 2, 2025
@sbernauer sbernauer marked this pull request as ready for review January 8, 2025 09:52
@sbernauer sbernauer self-assigned this Jan 8, 2025
@sbernauer sbernauer requested a review from maltesander January 13, 2025 08:10
maltesander
maltesander previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicking, LGTM otherwise :)

crates/stackable-operator/src/role_utils.rs Outdated Show resolved Hide resolved
@sbernauer sbernauer requested a review from maltesander January 15, 2025 07:33
maltesander
maltesander previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

maltesander
maltesander previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer requested a review from maltesander January 16, 2025 09:40
maltesander
maltesander approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer enabled auto-merge January 16, 2025 09:42
@sbernauer sbernauer added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 1bb891c Jan 16, 2025
10 checks passed
@sbernauer sbernauer deleted the feat/jvm-arguments branch January 16, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @maltesander