Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add vendor label to deployed third-party resources #9

Merged
merged 8 commits into from
Feb 2, 2024
Merged

feat: Add vendor label to deployed third-party resources #9

merged 8 commits into from
Feb 2, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi self-assigned this Dec 18, 2023
@Techassi Techassi mentioned this pull request Jan 30, 2024
Closed
@Techassi Techassi changed the title feat: Add labels to deployed resources feat: Add vednor label to deployed resources Jan 30, 2024
@Techassi Techassi changed the title feat: Add vednor label to deployed resources feat: Add vendor label to deployed resources Jan 30, 2024
@Techassi Techassi marked this pull request as ready for review January 30, 2024 10:10
@adwk67 adwk67 self-requested a review January 30, 2024 12:24
adwk67
adwk67 requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few places where values do not get "passed through" but I guess these are largely out of our control.

stacks/airflow/airflow.yaml Outdated Show resolved Hide resolved
stacks/_templates/minio.yaml Show resolved Hide resolved
stacks/_templates/opensearch-dashboards.yaml Show resolved Hide resolved
stacks/_templates/prometheus-service-monitor.yaml Show resolved Hide resolved
stacks/_templates/prometheus-service-monitor.yaml Show resolved Hide resolved
stacks/_templates/prometheus.yaml Show resolved Hide resolved
stacks/_templates/postgresql-timescaledb.yaml Outdated Show resolved Hide resolved
stacks/_templates/postgresql-timescaledb.yaml Show resolved Hide resolved
stacks/signal-processing/jupyterhub.yaml Outdated Show resolved Hide resolved
stacks/_templates/jupyterhub.yaml Outdated Show resolved Hide resolved
@Techassi
Copy link
Member Author

Techassi commented Feb 1, 2024

Removed all vendor labels from the demo/stack manifests as discussed in today's (2024-02-01) meeting.

@Techassi Techassi requested review from adwk67 and sbernauer February 1, 2024 15:15
@Techassi Techassi changed the title feat: Add vendor label to deployed resources feat: Add vendor label to deployed third-party resources Feb 1, 2024
adwk67
adwk67 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. There are still some labels that do not get passed through but not much we can do about that: the main thing is that the errors are gone. Thanks!

sbernauer
sbernauer approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

demos/nifi-kafka-druid-water-level-data/create-druid-ingestion-job.yaml Show resolved Hide resolved
@Techassi Techassi added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit b1b0933 Feb 2, 2024
1 check passed
@Techassi Techassi deleted the feat/labels branch February 2, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@adwk67 adwk67 adwk67 approved these changes

Assignees

@Techassi Techassi

Labels
release/24.3.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Techassi @adwk67 @sbernauer @lfrancke