Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(opa): Bump to 1.0.0 #143

Merged
merged 3 commits into from
Jan 24, 2025
Merged

chore(opa): Bump to 1.0.0 #143

merged 3 commits into from
Jan 24, 2025

Conversation

Maleware
Copy link
Contributor

sbernauer
sbernauer requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please grep for OpaCluster and change all 6 occurrences.
Can you please also remove all import rego.v1?
According to https://docs.styra.com/regal/rules/imports/use-rego-v1 they are not needed any more

The same applies to all tests/docs/whatnot

@Maleware
Copy link
Contributor Author

@sbernauer done. Thanks for your review.

sbernauer
sbernauer approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as well!
Ideally we test one demo before merging just to make sure we don't break everything 😅

@Maleware
Copy link
Contributor Author

Deployed end-to-end-security one more time. Worked as expected :)

@Maleware Maleware added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit de005da Jan 24, 2025
2 checks passed
@Maleware Maleware deleted the chore/update-opa-to-1.0.0 branch January 24, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maleware @sbernauer