Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog #2090

Merged
merged 6 commits into from
Nov 18, 2023
Merged

Add changelog #2090

merged 6 commits into from
Nov 18, 2023

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Nov 17, 2023

Add a changelog inspired by https://keepachangelog.com/en/1.1.0/

@jorisv jorisv self-assigned this Nov 17, 2023
@hrp2-14
Copy link

hrp2-14 commented Nov 17, 2023

Hi ! This project doesn't usually accept pull requests on the main branch.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

@jorisv jorisv changed the base branch from master to devel November 17, 2023 09:03
@jorisv jorisv marked this pull request as ready for review November 17, 2023 11:25
@jorisv jorisv requested a review from jcarpent November 17, 2023 11:25
jcarpent
jcarpent previously approved these changes Nov 17, 2023
View reviewed changes
@jorisv jorisv force-pushed the topic/add_changelog branch from 9d28a19 to 53be696 Compare November 17, 2023 13:16
@jorisv jorisv marked this pull request as draft November 17, 2023 13:16
@jcarpent
Copy link
Contributor

@jorisv Could you fix the issue with Codacy Static Code Analysis?

@jorisv
Copy link
Contributor Author

jorisv commented Nov 17, 2023

@jorisv Could you fix the issue with Codacy Static Code Analysis?

@jcarpent I prefer disable the check on CHANGELOG.md when the PR will be merged. Codacy want to have a different markdown style than the one proposed by keepachangelog.

@jorisv jorisv marked this pull request as ready for review November 17, 2023 13:59
@jorisv jorisv requested a review from nim65s November 17, 2023 14:00
nim65s
nim65s approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks !

@jcarpent jcarpent merged commit 7f9be4c into stack-of-tasks:devel Nov 18, 2023
12 of 13 checks passed
@jorisv jorisv deleted the topic/add_changelog branch July 23, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nim65s nim65s nim65s approved these changes

@jcarpent jcarpent jcarpent left review comments

Assignees

@jorisv jorisv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorisv @hrp2-14 @jcarpent @nim65s