Added custom SMTP email server testing on the dashboard #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
N2D4
approved these changes
Dec 20, 2024
apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/emails/page-client.tsx
Outdated
Show resolved
Hide resolved
.vscode/settings.json
Outdated
| @@ -53,6 +56,7 @@ | |||
| "quetzallabs", | |||
| "rehype", | |||
| "reqs", | |||
| "retryable", | |||
There was a problem hiding this comment.
this is not a word (the correct spelling is retriable, but canRetry is probably better anyways; see below)
Suggested change
| "retryable", |
There was a problem hiding this comment.
Sure I will change it to canRetry
Comment on lines
+49
to
52
| export function isSecureEmailPort(port: number | string) { | ||
| let parsedPort = parseInt(port.toString()); | ||
| const secure = parsedPort === 465; | ||
| return { secure }; | ||
| return parsedPort === 465; | ||
| } |
There was a problem hiding this comment.
you can't determine whether an SMTP server uses TLS or not just by the port (eg. it may be on a different port such as 587, 2525, 25025, etc). Also, 465 is not recommended anyways: https://www.mailgun.com/blog/email/which-smtp-port-understanding-ports-25-465-587/
There was a problem hiding this comment.
Should we add a setting in the DB for TLS?
apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/emails/page-client.tsx
Outdated
Show resolved
Hide resolved
…/emails/page-client.tsx Co-authored-by: Konsti Wohlwend <[email protected]>
Co-authored-by: Konsti Wohlwend <[email protected]>
Co-authored-by: Konsti Wohlwend <[email protected]>
Co-authored-by: Konsti Wohlwend <[email protected]>
…/emails/page-client.tsx Co-authored-by: Konsti Wohlwend <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add custom SMTP email server testing feature with backend error handling and frontend UI components.
send-test-emailroute inroute.tsxfor handling test email requests.sendEmailWithKnownErrorTypes()inemails.tsxfor error-handled email sending.isSecureEmailPort()inemails.tsxto check for secure ports.TestSendingDialogandEditEmailServerDialoginpage-client.tsxfor email server testing and configuration.FormDialoginform-dialog.tsxto handle form changes and prevent-close behavior.emailConfigSchemainprojects.tsto export schema.sendTestEmail()method toStackAdminInterfaceinadminInterface.tsandstack-app.ts.This description was created by
for b6e7e09. It will automatically update as commits are pushed.