Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove date column in DiseasystoreGoogleCovid19 #45

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Oct 5, 2023

Intent

fixes #44

Approach

Removed the date column from the output of google_covid_19_metric

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d118eb8) 96.06% compared to head (d6d44dd) 96.05%.

❗ Current head d6d44dd differs from pull request most recent head 4661c11. Consider uploading reports for the commit 4661c11 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   96.06%   96.05%   -0.02%     
==========================================
  Files          11       11              
  Lines         686      684       -2     
==========================================
- Hits          659      657       -2     
  Misses         27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RasmusSkytte RasmusSkytte self-assigned this Oct 9, 2023
@RasmusSkytte RasmusSkytte marked this pull request as ready for review October 9, 2023 11:24
@RasmusSkytte RasmusSkytte requested review from marcusmunch, kaare-gr and a team and removed request for marcusmunch and kaare-gr October 9, 2023 11:25
@RasmusSkytte RasmusSkytte requested review from a team and kaare-gr and removed request for a team November 10, 2023 09:12
@RasmusSkytte RasmusSkytte merged commit c985c7f into main Nov 14, 2023
11 checks passed
@RasmusSkytte RasmusSkytte deleted the googlecovid19_date branch November 14, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiseasystoreGoogleCovid19: remove redundant date column
2 participants