Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiseasystoreGoogleCovid19: remove redundant date column #44

Closed
RasmusSkytte opened this issue Oct 5, 2023 · 2 comments · Fixed by #45
Closed

DiseasystoreGoogleCovid19: remove redundant date column #44

RasmusSkytte opened this issue Oct 5, 2023 · 2 comments · Fixed by #45
Assignees
Milestone

Comments

@RasmusSkytte
Copy link
Contributor

In DiseasystoreGoogleCovid19, the translation from Google metrics to feature store keeps the date column.
However, this information is used to define the valid_from/until columns and are afterwards redundant.
Keeping the date column is more confusing that removing it, since it presents itself just as stratifications/observables does.

Removing the column will increase readability of the outputs and not cause loss of functionality

@RasmusSkytte
Copy link
Contributor Author

RasmusSkytte commented Oct 9, 2023

The github action for R-CMD-Check is failing on macOS. Seems to be related to this vroom issue

@RasmusSkytte
Copy link
Contributor Author

Since workaround introduced in PR #48 , the github actions work again

@RasmusSkytte RasmusSkytte added this to the v0.1 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant