-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind together userland #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mic component store
…frontend code are separate
…ntend-prototype into bind-together-userland
…ntend-prototype into bind-together-userland
…ntend-prototype into bind-together-userland
Quality Gate failedFailed conditions |
lkeegan
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have user landing page when they are logged in with two tabs: one for user data one for all the children stuff
some steps towards single page app:
add a store for components
add possibility for
Breadcrumbs
component to have onclick event & button instead of linkuse on:click event to make dynamic loading of components possible in a single page with breadcrumbs
make it such that the children components are rendered into the tab on the landing page. Breadcrumbs used for navigation within children area as it was. Most routes are mad obsolete by this, which hence have been deleted.
refactor out crappy logic stuff that will be replaced by backend calls into file called
*Componentname*.ts
. Everything needed for the actual function of the frontend (e.g., search logic (?)) remains in the*Componentname*.svelte
. That will hopefully make it easier to replace it as the frontend matures.still missing:
CardDisplay
andGalleryDisplay
Sonarcloud is complaining because of the milestone dummy data being copied around.