Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind together userland #95

Merged
merged 47 commits into from
Sep 27, 2024
Merged

Bind together userland #95

merged 47 commits into from
Sep 27, 2024

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Sep 27, 2024

  • have user landing page when they are logged in with two tabs: one for user data one for all the children stuff

  • some steps towards single page app:

  • add a store for components

  • add possibility for Breadcrumbs component to have onclick event & button instead of link

  • use on:click event to make dynamic loading of components possible in a single page with breadcrumbs

  • make it such that the children components are rendered into the tab on the landing page. Breadcrumbs used for navigation within children area as it was. Most routes are mad obsolete by this, which hence have been deleted.

  • refactor out crappy logic stuff that will be replaced by backend calls into file called *Componentname*.ts . Everything needed for the actual function of the frontend (e.g., search logic (?)) remains in the *Componentname*.svelte. That will hopefully make it easier to replace it as the frontend matures.

  • still missing:

    • separate page/component to display children data for each child --> separate PR
    • some remaining styling issues in CardDisplay and GalleryDisplay
    • milestone itself is only integrated via a separate page. It's a rather complicated component with a lot of internal functionality that made imho too cumbersome to integrate and adjust it to fit into the new scheme.
  • Sonarcloud is complaining because of the milestone dummy data being copied around.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 917 lines in your changes missing coverage. Please review.

Project coverage is 19.43%. Comparing base (908718a) to head (8b0c4ba).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...rontend/src/lib/components/ChildrenRegistration.ts 0.00% 213 Missing and 1 partial ⚠️
frontend/src/lib/components/MilestoneGroup.ts 0.00% 195 Missing and 1 partial ⚠️
frontend/src/lib/components/ChildrenGallery.ts 0.00% 71 Missing and 1 partial ⚠️
...ontend/src/lib/components/MilestoneOverview.svelte 0.00% 71 Missing ⚠️
frontend/src/lib/components/MilestoneGroup.svelte 0.00% 66 Missing ⚠️
frontend/src/lib/components/ChildrenGallery.svelte 0.00% 48 Missing and 1 partial ⚠️
...end/src/lib/components/ChildrenRegistration.svelte 0.00% 38 Missing ⚠️
frontend/src/lib/components/UserLandingPage.svelte 0.00% 27 Missing and 1 partial ⚠️
frontend/src/lib/stores/componentStore.ts 0.00% 24 Missing and 1 partial ⚠️
...rontend/src/routes/userLand/userLogin/+page.svelte 0.00% 23 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   18.10%   19.43%   +1.33%     
==========================================
  Files          75       75              
  Lines        3116     3371     +255     
  Branches      108      106       -2     
==========================================
+ Hits          564      655      +91     
- Misses       2497     2663     +166     
+ Partials       55       53       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MaHaWo MaHaWo requested a review from lkeegan September 27, 2024 14:04
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lkeegan lkeegan merged commit e02fb75 into main Sep 27, 2024
6 of 7 checks passed
@lkeegan lkeegan deleted the bind-together-userland branch September 27, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants