-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add abstract page content skeleton #8
Conversation
…ey-frontend-prototype into create-abstract-content-page
One question remains for me: where to put stylings? It seems that the idea is to apply them directly to wherever you need them in your component, but that seems to be an oddly non-reusable paradigm, since component styling and component functions do not necessarily correlate 100%? And having a global style sheet in which to maintain everything seems like a recipe for desaster? |
what tests would be necessary at this point? there is no functionality yet, so I didn't really write any tests either.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I think that in general <script>
is not the place for styling - I'd suggest putting them directly in class=...
and if that would result in duplication I'd suggest making a re-usable component with this styling.
src/lib/components/Frontpage.svelte
Outdated
<Card class={cardStyle}> | ||
<h5 class={headerStyle}>Was ist Mondey?</h5> | ||
<p class={paragraphStyle}> | ||
<i>Mondey</i> ist ein wissentschaftlich geprüftes Programm zure Dokumentation der Entwicklung von | ||
Kindern bis 6 Jahren. | ||
</p> | ||
<Button class={buttonStyle}>Mehr Info <ArrowRightOutline class={arrowStyle} /></Button> | ||
</Card> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to make custom Card component that can be reused here, with inline component styling, the header text as a prop, and a slot for the content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was thinking about this. but given that this is a dummy page and Mrs. Pauen wanted to design the page herself, I didn´t go to these lengths. Or do you think we should use the cards therein/somewhere else? In that case I would suggest having a separate issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree - we can look at adding some cypress ui tests at some point, but I wouldn't start doing this until we have pretty much solidified the design. |
AbstractContent
component do something.