Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new accordion element on the front page #208

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

Majapur1
Copy link
Collaborator

New element on the front page

  • add an accordion element with an information about the project with a function to parsing markdown from de.json (that helps to avoid a huge amount of lines in de.json for just one markdowned description);
  • update of de.json file;
  • add some extra additional colors into tailwind.config.ts.

@Majapur1 Majapur1 added javascript Pull requests that update Javascript code frontend labels Dec 13, 2024
@Majapur1 Majapur1 requested a review from lkeegan December 13, 2024 10:02
@Majapur1 Majapur1 self-assigned this Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 1.36%. Comparing base (b986ca3) to head (bbe150f).

Files with missing lines Patch % Lines
frontend/tailwind.config.ts 0.00% 12 Missing ⚠️
...ntend/src/lib/components/FrontPageAccordion.svelte 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #208      +/-   ##
========================================
- Coverage   1.37%   1.36%   -0.01%     
========================================
  Files         86      87       +1     
  Lines       2771    2787      +16     
  Branches      98      99       +1     
========================================
  Hits          38      38              
- Misses      2650    2665      +15     
- Partials      83      84       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Majapur1 - as we just discussed, I'd suggest that for now

@Majapur1 Majapur1 requested a review from lkeegan December 16, 2024 14:45
@lkeegan lkeegan force-pushed the frontpage-accordion branch from 83aa8cc to bbe150f Compare January 10, 2025 12:22
@lkeegan lkeegan merged commit 5d818cf into main Jan 10, 2025
7 of 8 checks passed
@lkeegan lkeegan deleted the frontpage-accordion branch January 10, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants