Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Componentize front page better #14

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Aug 21, 2024

This is a little refactoring PR:

  • makes smaller components:

    • bottom navbar items that link somewhere
    • top bar icons with tooltip
    • cards with header, summary and button to link
  • put top navbar into outermost +layout.svelte because we will have it everywhere.

eventually, AbstractContent.svelte will go away when we have more pages and the link hierarchy becomes apparent, such that elements that are needed everywhere can be put into the +layout.svelte files. The bottom navbar can be used for everything inside a Bestandsaufnahme (survey/stock taking) for example, or for the registration process.

@MaHaWo MaHaWo requested a review from lkeegan August 21, 2024 13:54
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@MaHaWo MaHaWo merged commit b004afb into main Aug 21, 2024
2 checks passed
@MaHaWo MaHaWo deleted the componentize-front-page-better branch August 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants