Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace prettier/eslint with biome #137

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Replace prettier/eslint with biome #137

merged 3 commits into from
Oct 30, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Oct 29, 2024

  • add biome to pre-commit config
  • add biome config: for now exclude all failing linter rules
    • in the future we can remove these one by one and fix the code
  • remove pnpm format from codegen ci
  • remove pnpm format commands
  • remove prettier/eslint configs and installs
  • resolves Replace eslint/prettier with biome #124

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.59441% with 1350 lines in your changes missing coverage. Please review.

Project coverage is 26.04%. Comparing base (1ed8ef3) to head (94b5422).

Files with missing lines Patch % Lines
...rontend/src/lib/components/ChildrenRegistration.ts 0.00% 100 Missing and 1 partial ⚠️
frontend/src/lib/components/UserDataInput.svelte 0.00% 82 Missing ⚠️
frontend/src/lib/components/MilestoneGroup.ts 0.00% 78 Missing and 1 partial ⚠️
frontend/src/lib/stores/contentStore.ts 0.00% 73 Missing and 1 partial ⚠️
...ontend/src/lib/components/MilestoneOverview.svelte 0.00% 72 Missing ⚠️
...rontend/src/lib/components/UserRegistration.svelte 0.00% 69 Missing ⚠️
frontend/src/lib/components/MilestoneGroup.svelte 0.00% 62 Missing ⚠️
frontend/src/lib/components/Frontpage.svelte 0.00% 59 Missing ⚠️
frontend/src/lib/components/Milestone.svelte 0.00% 55 Missing ⚠️
...nd/src/lib/components/Admin/MilestoneGroups.svelte 0.00% 50 Missing ⚠️
... and 46 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   26.12%   26.04%   -0.08%     
==========================================
  Files          92       92              
  Lines        3369     3501     +132     
  Branches      119      121       +2     
==========================================
+ Hits          880      912      +32     
- Misses       2423     2523     +100     
  Partials       66       66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkeegan lkeegan force-pushed the fix_124_replace_prettier_with_biome branch 5 times, most recently from 0ecbc75 to 01f05f5 Compare October 29, 2024 16:00
@lkeegan
Replace prettier/eslint with biome
ea7e408 
- add biome to pre-commit config
- add biome config
  - for now exclude all failing linter rules
    - in the future we can remove these one by one and fix the code
  - set recommended overrides for svelte to avoid biome breaking svelte-specific stuff
    - https://biomejs.dev/internals/language-support/#html-super-languages-support
- exclude auto-generated files from pre-commit
- remove pnpm format from codegen ci
- remove pnpm format commands
- remove prettier/eslint configs and installs
- resolves #124
@lkeegan lkeegan force-pushed the fix_124_replace_prettier_with_biome branch from b197756 to ea7e408 Compare October 29, 2024 16:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@lkeegan lkeegan requested a review from MaHaWo October 29, 2024 16:08
MaHaWo
MaHaWo approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@MaHaWo MaHaWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MaHaWo MaHaWo merged commit b482ac0 into main Oct 30, 2024
5 of 6 checks passed
@MaHaWo MaHaWo deleted the fix_124_replace_prettier_with_biome branch October 30, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaHaWo MaHaWo MaHaWo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace eslint/prettier with biome
3 participants
@lkeegan @codecov-commenter @MaHaWo