Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #120 "Add milestone age groups" #135

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Oct 25, 2024

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.

Project coverage is 23.76%. Comparing base (5fac037) to head (98a8bfa).

Files with missing lines Patch % Lines
frontend/src/lib/admin.svelte.ts 0.00% 5 Missing ⚠️
frontend/src/routes/admin/+page.svelte 0.00% 5 Missing ⚠️
...nd/src/lib/components/Admin/MilestoneGroups.svelte 0.00% 3 Missing ⚠️
frontend/src/routes/milestone/+page.svelte 0.00% 2 Missing ⚠️
frontend/src/lib/stores/adminStore.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   24.29%   23.76%   -0.54%     
==========================================
  Files          94       93       -1     
  Lines        3836     3707     -129     
  Branches      121      120       -1     
==========================================
- Hits          932      881      -51     
+ Misses       2836     2759      -77     
+ Partials       68       67       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkeegan lkeegan requested a review from MaHaWo October 25, 2024 13:13
@lkeegan lkeegan force-pushed the fix_131_remove_milestone_age_group branch from aa22251 to 98a8bfa Compare October 25, 2024 13:19
Copy link

Copy link
Collaborator

@MaHaWo MaHaWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaHaWo MaHaWo merged commit 83b2e59 into main Oct 28, 2024
5 checks passed
@MaHaWo MaHaWo deleted the fix_131_remove_milestone_age_group branch October 28, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove MilestoneAgeGroups
3 participants