Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstract dropdown page #12

Merged
merged 16 commits into from
Aug 21, 2024
Merged

Add abstract dropdown page #12

merged 16 commits into from
Aug 21, 2024

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Aug 21, 2024

  • adds a simple dropdown page with the actual content being passed as arguments.
    • add component for selection of categorical data
    • add component that eats an array of data objects
  • creates a dummydropdown component to see how it works.
  • adds routes from frontpage to dropdown to next dropdown page, just to make it do something for now.
  • adds route for infopage (temporary).

@MaHaWo MaHaWo requested a review from lkeegan August 21, 2024 08:34
@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Aug 21, 2024

  • changes since last discussion:
    • get rid of js class
    • componentize the data selection a bit better
    • make the selection element more exchangeable

@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Aug 21, 2024

@lkeegan you want to have another look?

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@MaHaWo MaHaWo merged commit fff3a6e into main Aug 21, 2024
2 checks passed
@MaHaWo MaHaWo deleted the add-abstract-dropdown-page branch August 21, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants