Add backend connection to user login #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MaHaWo
commented
Oct 15, 2024
•
MaHaWo
commented
- make use of backend functionality in login, profile popover and user registration
- add localization where needed
- add 'success' page to user registration
- add error handling where necessary
- make better usage of forms
- wrt roles: Currently a user can request a role upon registration, and then would get an e-mail with further instructions on how to get that role (provide verification of a research institution or special admin access token or whatever). The rest of the verification process would then be:
- normal observer: click link and be done, as normal
- researcher: verify with institution?
- admin: verify with admin token (whatever that may be) obtained from an existing admin?
- currently, only the role request is implemented in the frontend.
- is there a standard process for this?
- Question: does the role have to go into the login too? or should this be automatically determined from the database? ( I assume the latter)
- missing currently:
- english translations
- users remain unverified add email to backend #109
- no 'reset password' functionality yet in itself. that would have to happen in the user landing page under an additional tab? (can be a late addition imho...)
- no integration with the admin user stuff yet.
…ion-to-user-login
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 16.15% 16.23% +0.07%
==========================================
Files 97 98 +1
Lines 4846 4829 -17
Branches 124 125 +1
==========================================
+ Hits 783 784 +1
+ Misses 3994 3975 -19
- Partials 69 70 +1 ☔ View full report in Codecov by Sentry. |
…iwr/mondey-frontend-prototype into add-backend-connection-to-user-login
…iwr/mondey-frontend-prototype into add-backend-connection-to-user-login
lkeegan
approved these changes
Oct 16, 2024
Comment on lines
24
to
26
| // TODO: remove this in the final version, this sets verified to true | ||
| // to emulate a successful user registration | ||
| returned.data.is_verified = true; |
There was a problem hiding this comment.
I think it makes more sense to make the backend set is_verified=true on signup for now until #109 is implemented
There was a problem hiding this comment.
ok... did that now in on_after_register in the users.py file. find entry in database corresponding to the passed user object, set the verified flag -> write back to database.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.