Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Children to backend #114

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Add Children to backend #114

merged 1 commit into from
Oct 16, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Oct 15, 2024

  • add Child model and routes
    • only the user who owns the child can access these routes
  • add STATIC_FILES_PATH to settings
    • this is where non-public files are stored, e.g. child images
  • fix user dependency injection in tests
  • add public client with no user authentification to tests
  • resolves add Children to backend #111

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 31.84080% with 137 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (41acbad) to head (2d4936b).

Files with missing lines Patch % Lines
frontend/src/lib/client/schemas.gen.ts 0.00% 64 Missing ⚠️
frontend/src/lib/client/services.gen.ts 0.00% 54 Missing ⚠️
mondey_backend/src/mondey_backend/routers/users.py 68.33% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   15.56%   16.15%   +0.58%     
==========================================
  Files          96       97       +1     
  Lines        4650     4846     +196     
  Branches      124      124              
==========================================
+ Hits          724      783      +59     
- Misses       3857     3994     +137     
  Partials       69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- add Child model and routes
  - only the user who owns the child can access these routes
- add STATIC_FILES_PATH to settings
  - this is where non-public files are stored, e.g. child images
- fix user dependency injection in tests
- add public client with no user authentification to tests
- resolves #111
@lkeegan lkeegan force-pushed the fix_111_add_children branch from 706473c to 2d4936b Compare October 15, 2024 12:35
Copy link

@lkeegan lkeegan requested a review from MaHaWo October 15, 2024 12:38
Copy link
Collaborator

@MaHaWo MaHaWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaHaWo MaHaWo merged commit 3b8b826 into main Oct 16, 2024
5 checks passed
@MaHaWo MaHaWo deleted the fix_111_add_children branch October 16, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Children to backend
3 participants