Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor localisation #107

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Refactor localisation #107

merged 3 commits into from
Oct 15, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Oct 15, 2024

  • User frontend
    • Default language is german with text stored in locales/de.json
      • This is part of the frontend build and so cannot be edited from the backend
    • All other languages are no longer part of the git repo
      • These are fetched as json files from the server
      • These can be edited from the backend
  • Admin frontend
    • Add interface for editing translations of frontend text
  • Backend
    • Add endpoint to update an 18n translation json file
  • resolves Consolidate localisation #79

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 9.70874% with 93 lines in your changes missing coverage. Please review.

Project coverage is 15.56%. Comparing base (1fbb03d) to head (2c14765).

Files with missing lines Patch % Lines
...ntend/src/lib/components/Admin/Translations.svelte 0.00% 34 Missing and 1 partial ⚠️
frontend/src/lib/i18n.ts 0.00% 31 Missing and 1 partial ⚠️
frontend/src/lib/client/services.gen.ts 0.00% 8 Missing ⚠️
frontend/src/lib/components/Admin/Languages.svelte 0.00% 5 Missing ⚠️
frontend/src/routes/+layout.svelte 0.00% 4 Missing ⚠️
frontend/src/lib/components/Milestone.svelte 0.00% 2 Missing ⚠️
frontend/src/routes/admin/+page.svelte 0.00% 2 Missing ⚠️
...ib/components/Admin/EditMilestoneGroupModal.svelte 0.00% 1 Missing ⚠️
...src/lib/components/Admin/EditMilestoneModal.svelte 0.00% 1 Missing ⚠️
.../lib/components/Admin/EditUserQuestionModal.svelte 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   15.64%   15.56%   -0.08%     
==========================================
  Files          95       96       +1     
  Lines        4571     4650      +79     
  Branches      123      124       +1     
==========================================
+ Hits          715      724       +9     
- Misses       3788     3857      +69     
- Partials       68       69       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- User frontend
  - Default language is german with text stored in locales/de.json
    - This is part of the frontend build and so cannot be edited from the backend
  - All other languages are no longer part of the git repo
    - These are fetched as json files from the server
    - These can be edited from the backend
- Admin frontend
  - Add interface for editing translations of frontend text
- Backend
  - Add endpoint to update an 18n translation json file
- resolves #79
@lkeegan lkeegan force-pushed the combine_localization branch from f4fc2db to 1b24ea6 Compare October 15, 2024 07:56
@lkeegan lkeegan requested a review from MaHaWo October 15, 2024 07:58
- User frontend
  - Default language is german with text stored in locales/de.json
    - This is part of the frontend build and so cannot be edited from the backend
  - All other languages are no longer part of the git repo
    - These are fetched as json files from the server
    - These can be edited from the backend
- Admin frontend
  - Add interface for editing translations of frontend text
- Backend
  - Add endpoint to update an 18n translation json file
- resolves #79
@lkeegan lkeegan force-pushed the combine_localization branch from 1b24ea6 to f8eaaea Compare October 15, 2024 10:50
Copy link

Copy link
Collaborator

@MaHaWo MaHaWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaHaWo MaHaWo merged commit 41acbad into main Oct 15, 2024
5 checks passed
@MaHaWo MaHaWo deleted the combine_localization branch October 15, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate localisation
3 participants