Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new auto-generated client API in frontend admin interface #100

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Oct 8, 2024

  • remove api logic from admin.ts
  • simplify preview of uploaded images
  • add localised translations for more text elements
  • add localised alert message for invalid login attempt
  • fix inconsistent name of delete_user_question admin endpoint
  • don't generate separate Input and Output types in client API
    • by passing separate_input_output_schemas=False to get_openapi call

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0.90498% with 219 lines in your changes missing coverage. Please review.

Project coverage is 14.97%. Comparing base (aeb25ce) to head (c3382dc).

Files with missing lines Patch % Lines
...nd/src/lib/components/Admin/MilestoneGroups.svelte 0.00% 64 Missing ⚠️
...ib/components/Admin/EditMilestoneGroupModal.svelte 0.00% 42 Missing ⚠️
...src/lib/components/Admin/EditMilestoneModal.svelte 0.00% 34 Missing ⚠️
...tend/src/lib/components/Admin/UserQuestions.svelte 0.00% 23 Missing ⚠️
.../lib/components/Admin/EditUserQuestionModal.svelte 0.00% 22 Missing ⚠️
frontend/src/lib/admin.ts 0.00% 11 Missing ⚠️
frontend/src/lib/components/Admin/Login.svelte 0.00% 9 Missing ⚠️
frontend/src/lib/components/Admin/Languages.svelte 0.00% 4 Missing ⚠️
frontend/src/lib/client/services.gen.ts 0.00% 3 Missing ⚠️
frontend/src/lib/stores/adminStore.ts 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   14.15%   14.97%   +0.81%     
==========================================
  Files          90       90              
  Lines        5064     4789     -275     
  Branches      118      118              
==========================================
  Hits          717      717              
+ Misses       4284     4009     -275     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkeegan lkeegan force-pushed the use_new_frontend_api branch from 58b01dc to ebab58d Compare October 9, 2024 07:11
- remove api logic from admin.ts
- simplify preview of uploaded images
- add localised translations for more text elements
- add localised alert message for invalid login attempt
- fix inconsistent name of delete_user_question admin endpoint
- don't generate separate Input and Output types in client API
  - by passing `separate_input_output_schemas=False` to get_openapi call
@lkeegan lkeegan force-pushed the use_new_frontend_api branch from ebab58d to c3382dc Compare October 9, 2024 07:11
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@lkeegan lkeegan merged commit aaa5152 into main Oct 9, 2024
6 of 7 checks passed
@lkeegan lkeegan deleted the use_new_frontend_api branch October 9, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants