Added a new example that seamlessly works across 2 different machines. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a nice simple example. It's not a test per-se (as in we wouldn't run it as part of automated tests) Can you speak more to why you wanted this @nuttwork ? |
|
I agree with you about it being unsuitable for a test in the current form.
I looked at other modules such as ssb-minimal-pub-server, ssb-client-basic,
etc. and none have an example that works across machines, so I wrote one
up...
…On Mon, Mar 27, 2023 at 5:38 PM mix irving ***@***.***> wrote:
This is a nice simple example. It's not a test per-se (as in we wouldn't
run it as part of automated tests)
I wonder if it could be converted into a single file that behaves as a
test and whether that would be useful.
Can you speak more to why you wanted this @nuttwork
<https://github.com/nuttwork> ?
—
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APR4L55RGSSQN4IT3N6GIFLW6IXJXANCNFSM6AAAAAAWB7JQUA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
If it's an example not a test, should we make a new |
ahdinosaur
reviewed
Mar 29, 2023
README.md
Outdated
Comment on lines
33
to
36
| Added talk.js and listen.js that can run on 2 different machines. | ||
| Usage: node listen.js | ||
| Then copy the key it prints and the host IP on which you ran listen.js and put it in talk.js | ||
| Usage: node talk.js |
There was a problem hiding this comment.
the markdown here doesn't display well, e.g. https://github.com/nuttwork/secret-stack/blob/example/README.md
might be better written like:
See also: [`talk.js`](./examples/talk.js) and [`listen.js`](./examples/listen.js)Where the rest of the documentation could be in those files.
|
I like @ahdinosaur suggestion of an examples folder. Lets do that. |
Changed markdown per suggestion from ahdinosaur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two files work together to form one example of how to communicate across machines.