Abandon test suite for
loops for pytest best practices
#16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
loops in the test suite have significant disadvantages. Among them: a single failing test input causes the entire test to fail, rather than failing the specific input combinations that can cause failure.While pytest output can help identify the specific failure inputs in the
for
loop, the best practice is to use pytest.mark.parametrize; this allows pytest to handle each parameter independently.This PR swaps out
for
loops in the test suite with pytest'spytest.mark.parametrize
decorator.